Skip to content

Enable CSP module and fix logical errors in CSP generation#8

Merged
kadamwhite merged 2 commits intomainfrom
fix-csp-application
Dec 11, 2023
Merged

Enable CSP module and fix logical errors in CSP generation#8
kadamwhite merged 2 commits intomainfrom
fix-csp-application

Conversation

@kadamwhite
Copy link
Copy Markdown
Collaborator

  • Need to separate the CSP code with a space; implode( $allowed_hosts ) was missing the glue string
  • Unify namespace naming to WMF
  • Don't bother passing $wp parameter to CSP header filter, it is not used
  • Bootstrap the CSP module so that this logic is applied

@MiguelAxcar MiguelAxcar self-requested a review December 11, 2023 15:54
@kadamwhite kadamwhite merged commit 688ebd0 into main Dec 11, 2023
@kadamwhite kadamwhite deleted the fix-csp-application branch December 11, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants