feat: support merging non-string sections#1306
feat: support merging non-string sections#1306davidlattimore merged 8 commits intowild-linker:mainfrom
Conversation
|
This is WIP but I wanted to get some feedback.
|
davidlattimore
left a comment
There was a problem hiding this comment.
Awesome!
Regarding doing lots of renames of string-merging to section-merging, I'd say don't worry too much. I'd say probably update the comment at the top of string_merging.rs to say that the code also handles merging of non-string sections. If we do decide to do lots of renames, they should probably be done in a separate PR, but it's probably fine to leave things as you've got them.
Anyway, I think this is basically good to merge.
0c86650 to
f1e1dc5
Compare
|
Glad to hear that. I added a few commits that addressed you comments and did minor refactor and improved docs. |
|
The ubuntu 24.04 on aarch64 check failure looks like some CI issue. |
|
Yeah, AArch64 GHA runners do that sometimes. |
Implements #838.