Skip to content

fix: Make --whole-archive work with linker plugins#1900

Merged
davidlattimore merged 1 commit intomainfrom
push-ymlnzoywpwym
May 7, 2026
Merged

fix: Make --whole-archive work with linker plugins#1900
davidlattimore merged 1 commit intomainfrom
push-ymlnzoywpwym

Conversation

@davidlattimore
Copy link
Copy Markdown
Member

Fixes #1897

@davidlattimore
Copy link
Copy Markdown
Member Author

I considered changing has_archive_semantics so that all callers would treat objects with --whole-archive as if they didn't have archive semantics. One of the callers was the code that handles --exclude-libs, so I added a test that checks the interaction of --exclude-libs and --whole-archive. The test demonstrated that they shouldn't interact, i.e. that having --whole-archive prevent --exclude-libs from acting would be wrong, so I went with just updating the behaviour for the linker plugin driver.

@davidlattimore davidlattimore merged commit da8ef65 into main May 7, 2026
24 checks passed
@davidlattimore davidlattimore deleted the push-ymlnzoywpwym branch May 7, 2026 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LTO: wild: error: Undefined symbol WebPFree, referenced by

2 participants