Add ESLint configuration to fix CI lint job failure#10
Merged
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: wildhash <30030014+wildhash@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add ESLint configuration file for JavaScript and Solidity
Add ESLint configuration to fix CI lint job failure
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI lint job was failing because ESLint couldn't find a configuration file, causing the
npm run lintcommand to exit with code 2.Changes
Added
.eslintrc.jsonwith Node.js/ES2021/Mocha environment,eslint:recommended+prettierextends, and Hardhat globals (artifacts,ethers,network)Fixed linting errors by removing unused variables:
scripts/demo-scenario.js: removed unusedtaskAfterSubmittest/AgentEscrowMNEE.test.js: removed unused destructured variables (payer,mnee)Configuration
{ "env": { "node": true, "es2021": true, "mocha": true }, "extends": ["eslint:recommended", "prettier"], "globals": { "artifacts": "readonly", "ethers": "readonly", "network": "readonly" }, "rules": { "no-unused-vars": ["error", { "argsIgnorePattern": "^_" }], "no-console": "off" } }Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
binaries.soliditylang.org/usr/local/bin/node node /home/REDACTED/work/agentpay/agentpay/node_modules/.bin/hardhat test(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
This pull request was created from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.