Skip to content

Add ESLint configuration to fix CI lint job failure#10

Merged
wildhash merged 2 commits intomainfrom
copilot/add-eslint-configuration-file
Jan 11, 2026
Merged

Add ESLint configuration to fix CI lint job failure#10
wildhash merged 2 commits intomainfrom
copilot/add-eslint-configuration-file

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 11, 2026

The CI lint job was failing because ESLint couldn't find a configuration file, causing the npm run lint command to exit with code 2.

Changes

  • Added .eslintrc.json with Node.js/ES2021/Mocha environment, eslint:recommended + prettier extends, and Hardhat globals (artifacts, ethers, network)

  • Fixed linting errors by removing unused variables:

    • scripts/demo-scenario.js: removed unused taskAfterSubmit
    • test/AgentEscrowMNEE.test.js: removed unused destructured variables (payer, mnee)

Configuration

{
  "env": { "node": true, "es2021": true, "mocha": true },
  "extends": ["eslint:recommended", "prettier"],
  "globals": { "artifacts": "readonly", "ethers": "readonly", "network": "readonly" },
  "rules": {
    "no-unused-vars": ["error", { "argsIgnorePattern": "^_" }],
    "no-console": "off"
  }
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • binaries.soliditylang.org
    • Triggering command: /usr/local/bin/node node /home/REDACTED/work/agentpay/agentpay/node_modules/.bin/hardhat test (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Problem

The CI workflow is failing on job 60023559506 because ESLint cannot find a configuration file. The error message states:

ESLint looked for configuration files in /home/runner/work/agentpay/agentpay and its ancestors. If it found none, it then looked in your home directory.
Process completed with exit code 2.

This is causing the lint job in the CI workflow (.github/workflows/ci.yml) to fail when running npm run lint (line 61).

Solution Required

Create an appropriate ESLint configuration file for this JavaScript/Solidity project. The repository has the following language composition:

  • JavaScript: 63.8%
  • HTML: 16.3%
  • Solidity: 14.4%
  • Python: 5.5%

The configuration should:

  1. Support Node.js and ES2021+ JavaScript features
  2. Include appropriate rules for the project
  3. Work with the existing lint command in the package.json
  4. Be placed in the repository root directory

Suggested approach:

  • Create a .eslintrc.json or .eslintrc.js file in the root directory
  • Configure it for Node.js/ES2021 environment
  • Use eslint:recommended as a base or configure rules as appropriate
  • Ensure it integrates with any existing Solidity linting setup

Reference

This pull request was created from Copilot chat.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 11, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Co-authored-by: wildhash <30030014+wildhash@users.noreply.github.com>
Copilot AI changed the title [WIP] Add ESLint configuration file for JavaScript and Solidity Add ESLint configuration to fix CI lint job failure Jan 11, 2026
Copilot AI requested a review from wildhash January 11, 2026 08:00
@wildhash wildhash marked this pull request as ready for review January 11, 2026 08:16
@wildhash wildhash merged commit 80ec853 into main Jan 11, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants