This repository was archived by the owner on Jan 15, 2024. It is now read-only.
Conversation
No automatic merging for facts defined in global test scope (https://github.com/rodjek/rspec-puppet/blob/master/CHANGELOG.md#263) Full evaluation for resource definitions, so now `::nodejs::instance::pkgs` needs to be evaluated before (or at least the needed packages with Puppet::Package)
Puppet 5.x ships with Ruby 2.4, but older Puppet versions (we still support Puppet 3.x) are obvioulsy incompatible. See affected build at https://travis-ci.org/willdurand/puppet-nodejs/builds/366517540
Collaborator
Author
|
@willdurand the tests for Puppet3 are currently broken (I'm working on a fix, seems to be a Travis issue), would be cool if you could have a short look at this :) |
Owner
ah sorry I missed that, will review it tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Updates our package set, uses Puppet5 for development by default.
For further details have a look at the commit messages...