Conversation
…f mattr_accessor Use the default option available since Rails 5.2. mattr_accessor internally accesses class variables, but this is not obvious and makes seed-do.rb harder to understand. Using the default option is more intuitive and easier to read. ref: [Implement mattr_acessor :default option · rails/rails@a5b0c60](rails/rails@a5b0c60)
There was a problem hiding this comment.
Pull request overview
This PR modernizes the code by using the default option of mattr_accessor (available since Rails 5.2) instead of directly accessing class variables. This change improves code readability and maintainability by making the default values more explicit and reducing the number of lines needed to define module attributes with defaults.
Key changes:
- Refactored
quietattribute to use inline default value - Refactored
fixture_pathsattribute to use inline default value
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fix typo Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the default option available since Rails 5.2. mattr_accessor internally accesses class variables, but this is not obvious and makes seed-do.rb harder to understand. Using the default option is more intuitive and easier to read.
ref: Implement mattr_acessor :default option · rails/rails@a5b0c60