add GCS cache#106
add GCS cache#106diegomarangoni wants to merge 0 commit intowillnorris:masterfrom diegomarangoni:master
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
@willnorris do you know why my build is not passing? |
|
looks like some libs are not working with Go 1.5 anymore. |
hmm, I suspect I broke that when I upgraded the vendored packages. :-\ As long as we're compatible with 1.8, I think we're fine though. |
|
Hope it is, I am running in production lol BTW, I didn't know how to correctly set vendor.json, so I leave without it. |
|
uh, wow... vendoring all the transitive dependencies brings in 57 new packages weighing about 4 MB. More concerning is that the resulting imageproxy binary doubles in size from ~7 MB to ~14 MB. Not your fault at all! this is just how the google cloud sdk is written. I'm just not sure how I feel about that :-\ |
|
maybe writing as a plugin? |
|
shoving the entire JSON key into an environment variable seems a little weird, but I guess it works, and is at least consistent with the other caching backends :) We can always adjust that later if needed. I'll rework these commits slightly and merge shortly. |
|
well, oops. I tried updating your branch with the updated commits and ended up breaking something which automatically closed this PR. That was weird. In any event, everything is now merged in. |
|
thanks @willnorris |
Add new option to cache assets on Google Cloud Storage