Skip to content

add GCS cache#106

Closed
diegomarangoni wants to merge 0 commit intowillnorris:masterfrom
diegomarangoni:master
Closed

add GCS cache#106
diegomarangoni wants to merge 0 commit intowillnorris:masterfrom
diegomarangoni:master

Conversation

@diegomarangoni
Copy link
Copy Markdown
Contributor

Add new option to cache assets on Google Cloud Storage

@googlebot
Copy link
Copy Markdown
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@diegomarangoni
Copy link
Copy Markdown
Contributor Author

I signed it!

@googlebot
Copy link
Copy Markdown
Collaborator

CLAs look good, thanks!

@diegomarangoni
Copy link
Copy Markdown
Contributor Author

@willnorris do you know why my build is not passing?

@diegomarangoni
Copy link
Copy Markdown
Contributor Author

looks like some libs are not working with Go 1.5 anymore.

@willnorris
Copy link
Copy Markdown
Owner

looks like some libs are not working with Go 1.5 anymore.

hmm, I suspect I broke that when I upgraded the vendored packages. :-\ As long as we're compatible with 1.8, I think we're fine though.

@diegomarangoni
Copy link
Copy Markdown
Contributor Author

Hope it is, I am running in production lol
Serving 240GB with no problems

BTW, I didn't know how to correctly set vendor.json, so I leave without it.

@willnorris
Copy link
Copy Markdown
Owner

uh, wow... vendoring all the transitive dependencies brings in 57 new packages weighing about 4 MB. More concerning is that the resulting imageproxy binary doubles in size from ~7 MB to ~14 MB. Not your fault at all! this is just how the google cloud sdk is written. I'm just not sure how I feel about that :-\

@diegomarangoni
Copy link
Copy Markdown
Contributor Author

maybe writing as a plugin?
well, 14MB still considerable small for me...
may turn into a mess if the number of functionalities increases.

@willnorris
Copy link
Copy Markdown
Owner

shoving the entire JSON key into an environment variable seems a little weird, but I guess it works, and is at least consistent with the other caching backends :) We can always adjust that later if needed. I'll rework these commits slightly and merge shortly.

@willnorris willnorris closed this Sep 1, 2017
@willnorris
Copy link
Copy Markdown
Owner

well, oops. I tried updating your branch with the updated commits and ended up breaking something which automatically closed this PR. That was weird. In any event, everything is now merged in.

@diegomarangoni
Copy link
Copy Markdown
Contributor Author

thanks @willnorris
upgrading my image to latest version ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants