Skip to content

Support TIFF images.#109

Closed
mikecx wants to merge 1 commit intowillnorris:masterfrom
CatchRelease:master
Closed

Support TIFF images.#109
mikecx wants to merge 1 commit intowillnorris:masterfrom
CatchRelease:master

Conversation

@mikecx
Copy link
Copy Markdown
Contributor

@mikecx mikecx commented Aug 31, 2017

fixes #107

@googlebot
Copy link
Copy Markdown
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@mikecx mikecx mentioned this pull request Aug 31, 2017
@mikecx
Copy link
Copy Markdown
Contributor Author

mikecx commented Aug 31, 2017

I signed it!

@googlebot
Copy link
Copy Markdown
Collaborator

CLAs look good, thanks!

Comment thread transform.go
return nil, err
}
case "jpeg", "webp": // default to encoding webp as jpeg
case "jpeg", "webp", "tiff": // default to encoding webp & tiff as jpeg
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can't we encode as tiff as well using https://godoc.org/golang.org/x/image/tiff#Encode ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we probably can. I was trying to make sure the file would be visible "in-browser" and generally tiff is not supported so it needs to be either jpg or png for that.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good call. I didn't realize how poorly supported tiff was in browsers :)

@mikecx mikecx closed this Aug 31, 2017
@willnorris
Copy link
Copy Markdown
Owner

c1a9dab merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TIFF Support

3 participants