Support TIFF images.#109
Support TIFF images.#109mikecx wants to merge 1 commit intowillnorris:masterfrom CatchRelease:master
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
| return nil, err | ||
| } | ||
| case "jpeg", "webp": // default to encoding webp as jpeg | ||
| case "jpeg", "webp", "tiff": // default to encoding webp & tiff as jpeg |
There was a problem hiding this comment.
why can't we encode as tiff as well using https://godoc.org/golang.org/x/image/tiff#Encode ?
There was a problem hiding this comment.
I suppose we probably can. I was trying to make sure the file would be visible "in-browser" and generally tiff is not supported so it needs to be either jpg or png for that.
There was a problem hiding this comment.
Ah, good call. I didn't realize how poorly supported tiff was in browsers :)
|
c1a9dab merged. |
fixes #107