Skip to content

Adds basic Prometheus support#121

Closed
benhaan wants to merge 2 commits intowillnorris:masterfrom
benhaan:master
Closed

Adds basic Prometheus support#121
benhaan wants to merge 2 commits intowillnorris:masterfrom
benhaan:master

Conversation

@benhaan
Copy link
Contributor

@benhaan benhaan commented Nov 10, 2017

New /metrics endpoint that Prometheus can scrape. Metrics provided include response times, image transformation time, remote fetch error count, and the number of requests served from cache.

I'm still new to Go, so any input/feedback on the implementation is appreciated.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@benhaan
Copy link
Contributor Author

benhaan commented Nov 10, 2017

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@alexesDev
Copy link

alexesDev commented Oct 21, 2019

@benhaan this is a good feature, but the branch not merged. Why?

@BrianGreenhill
Copy link

+1 for this feature 🙏

@willnorris
Copy link
Owner

Sorry for the long delay. Merged with a few minor changes.

@BrianGreenhill
Copy link

thank you @willnorris 🙏

vetler pushed a commit to vetler/imageproxy that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants