Skip to content

Copy header Link for canonical image SEO#68

Merged
willnorris merged 1 commit intowillnorris:masterfrom
xavren:master
Jun 7, 2016
Merged

Copy header Link for canonical image SEO#68
willnorris merged 1 commit intowillnorris:masterfrom
xavren:master

Conversation

@xavren
Copy link
Copy Markdown
Contributor

@xavren xavren commented Jun 7, 2016

@googlebot
Copy link
Copy Markdown
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

Comment thread imageproxy.go Outdated
copyHeader(w, resp, "Etag")

copyHeader(w, resp, "Link")

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove trailing space on this line. (or just run gofmt which will do this for you)

@googlebot
Copy link
Copy Markdown
Collaborator

CLAs look good, thanks!

@xavren
Copy link
Copy Markdown
Contributor Author

xavren commented Jun 7, 2016

i will do a clean rebase

@xavren xavren closed this Jun 7, 2016
@willnorris
Copy link
Copy Markdown
Owner

you don't need to close this PR to do a clean rebase. Just rebase your branch and force push to GitHub.

@willnorris willnorris reopened this Jun 7, 2016
@xavren
Copy link
Copy Markdown
Contributor Author

xavren commented Jun 7, 2016

You're right, here you go

@willnorris willnorris merged commit 79369ca into willnorris:master Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants