fix: prioritize guest cwd #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the terminal buffer changes directories, we should be able to open the intended file even if it matches the pathname in the Neovim current working directory. And even when the resulting path doesn't match any files, it likely means I want to start a new file.
willothy
approved these changes
Apr 2, 2023
Owner
willothy
left a comment
willothy
left a comment
There was a problem hiding this comment.
LGTM! I'll merge this later today. Thanks, not sure how I overlooked this haha
davidmh
added a commit
to davidmh/flatten.nvim
that referenced
this pull request
Apr 8, 2023
This is a follow-up to willothy#30. Removing the `vim.loop.fs_realpath` check helps with relative paths that exist in the guest, but it breaks absolute paths. For example, in a neovim terminal ```shell cd /tmp/ vim /tmp/a/file.txt ``` Would concatenate the path to `/tmp//tmp/a/file. I'm guessing checking for the real path was supposed to handle that scenario, it just conflicted with relative paths that matched the host cwd. This commit checks each file to see if it's absolute and avoid prepending the guest cwd.
davidmh
added a commit
to davidmh/flatten.nvim
that referenced
this pull request
Apr 8, 2023
This is a follow-up to willothy#30. Removing the `vim.loop.fs_realpath` check helps with relative paths that exist in the guest, but it breaks absolute paths. For example, in a neovim terminal ```shell cd /tmp/ vim /tmp/a/file.txt ``` Would concatenate the path to `/tmp//tmp/a/file. I'm guessing checking for the real path was supposed to handle that scenario, it just conflicted with relative paths that matched the host cwd. This commit checks each file to see if it's absolute and avoid prepending the guest cwd.
davidmh
added a commit
to davidmh/flatten.nvim
that referenced
this pull request
Apr 8, 2023
This is a follow-up to willothy#30. Removing the `vim.loop.fs_realpath` check helps with relative paths that exist in the guest, but it breaks absolute paths. For example, in a neovim terminal ```shell cd /tmp/ vim /tmp/a/file.txt ``` Would concatenate the path to `/tmp//tmp/a/file. I'm guessing checking for the real path was supposed to handle that scenario, it just conflicted with relative paths that matched the host cwd. This commit checks each file to see if it's absolute and avoid prepending the guest cwd.
willothy
pushed a commit
that referenced
this pull request
Apr 8, 2023
This is a follow-up to #30. Removing the `vim.loop.fs_realpath` check helps with relative paths that exist in the guest, but it breaks absolute paths. For example, in a neovim terminal ```shell cd /tmp/ vim /tmp/a/file.txt ``` Would concatenate the path to `/tmp//tmp/a/file. I'm guessing checking for the real path was supposed to handle that scenario, it just conflicted with relative paths that matched the host cwd. This commit checks each file to see if it's absolute and avoid prepending the guest cwd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @willothy,
Thank you for writing this plugin, it's has improved my workflow in a major way.
I noticed an unexpected behavior related to files from different working directories. When the terminal buffer changes directories, we should be able to open the intended file even if it matches the pathname in the Neovim current working directory.
And even when the resulting path doesn't match any files, it likely means I want to start a new file.
For example, having:
In a terminal buffer:
/tmp/example/a $ cd ../b /tmp/example/b $ vim README.md /tmp/example/b $I would expect
/tmp/example/b/README.mdto load in a new buffer, but I get/tmp/example/a/README.mdinstead.