Bugfix/#62 update jazzy#63
Merged
Ben Humphries (iMacHumphries) merged 12 commits intodevelopfrom May 10, 2019
Merged
Conversation
Contributor
Ben Humphries (iMacHumphries)
commented
May 9, 2019
Ben Humphries (iMacHumphries)
commented
- Fixes Update Jazzy #62
- Adds generate-docs.sh
- Generates new jazzy docs
Ben Humphries (iMacHumphries)
requested review from
Erik LaManna (eriklamanna),
Jeff Ward (fuzzybinary) and
Matt Kauper (mhk4g)
Ben Humphries (iMacHumphries)
requested a review
from Ameir Al-Zoubi (ameirwillowtree)
|
maybe we should automate the running of generate-docs.sh? Perhaps as a build phase? |
Contributor
|
I agree with Ameir Al-Zoubi (@ameirwillowtree), it might be better to remove and .gitignore the docs directory, and instead build and post them somewhere as part of the build process, especially since they're not easilly browsable in github. |
Contributor
Author
|
Jeff Ward (@fuzzybinary) I agree we should automate. Not sure about removing the docs from the repo 🤔 you can view the docs easily here https://willowtreeapps.github.io/Hyperion-iOS/ |
Ameir Al-Zoubi (ameirwillowtree)
approved these changes
May 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.