Skip to content

Remove Audio.raw #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waynemwashuma merged 2 commits into from
Aug 26, 2025
Merged

Remove Audio.raw #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1dd6b0
Remove `Audio.raw`
waynemwashuma Aug 7, 2025
e49bf97
Update `AudioParser`
waynemwashuma Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/audio/assets/audio.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,21 @@
export class Audio {

/**
* @type {AudioBuffer}
*/
audiobuffer

/**
* @param {AudioBuffer} audiobuffer
* @param {ArrayBuffer} raw
*/
constructor(audiobuffer, raw) {
constructor(audiobuffer) {
this.audiobuffer = audiobuffer
this.raw = raw
}

static default(){
return new Audio(new AudioBuffer({
sampleRate:44800,
length:1
}), new ArrayBuffer(0))
}))
}
}
2 changes: 1 addition & 1 deletion src/audio/resources/parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export class AudioParser extends Parser {
const raw = await response.arrayBuffer()
const audiobuffer = await this.decoder.decodeAudioData(raw)

return new Audio(audiobuffer, raw)
return new Audio(audiobuffer)
}

getExtensions(){
Expand Down