Restructure Query internals#244
Merged
Merged
Conversation
Ensure that the entity is actually contained in the query.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Restructure the
Querysystem by refining its API and strengthening integration withWorld,Archetypes, andTables. This change provides clearer semantics and improved safety checks.Added unit tests under to verify all core query operations, including:
Note
This introduces a performance regression as the queries no longer cache the table columns on creation.
Migration guide
Behavior of query methods remains consistent, but stricter checks are now enforced.
Checklist