Add an asset server#257
Merged
Merged
Conversation
These tests will be expanded later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Introduces an asset management system refactor, replacing the previous asset loading approach with a centralized asset server.
Solution
The previous asset system had loading logic distributed across multiple systems and plugins. This PR consolidates all asset loading management into a centralized
AssetServerthat:Other changes include:
AssetLoadSuccess) and failure (AssetLoadFail) events(now carrying typeId, assetId, and path).AssetBasePath.AssetServerPluginto set up the server and its supporting systems.AssetPluginandAssetParserPluginto interact with the server.The solution was taken to:
Showcase
Loading assets with the new
AssetServer:MigrationGuide
Several breaking changes have been introduced:
Assets.load()should be replaced withAssetServer.load()AssetServerinstead of individual asset systemsAssetBasePathresource has been removed, an alternative will be provided later.Checklist