Refactor BLE scan context for reliable timeout and fix context cancellation handling in BLE connection logic#142
Conversation
Scan context is now created from context.Background() to ensure the scan always gets the full scanTimeout duration, regardless of the parent context's remaining time. A goroutine is added to cancel the scan early if the parent context is cancelled, improving reliability and responsiveness.
Ensure context cancellation functions are called appropriately in connectToVehicleAndOperateConnection to prevent resource leaks. Simplify TryConnectToVehicle by removing unnecessary nil check for ctx.Done().
wimaha
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scan context is now created from context.Background() to ensure the scan always gets the full scanTimeout duration, regardless of the parent context's remaining time. A goroutine is added to cancel the scan early if the parent context is cancelled, improving reliability and responsiveness.
Ensure context cancellation functions are called appropriately in connectToVehicleAndOperateConnection to prevent resource leaks. Simplify TryConnectToVehicle by removing unnecessary nil check for ctx.Done().