Skip to content

Clean-up tests #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 25, 2021
Merged

Clean-up tests #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
52e1f36
Bump regex-to-strings dev dependency
wimpyprogrammer Jan 24, 2021
b4c83da
Remove CodeCov dev dependency
wimpyprogrammer Jan 24, 2021
1ea2640
Upgrade jest-when dependency to latest
wimpyprogrammer Jan 25, 2021
67cc218
Run test cases with it.each()
wimpyprogrammer Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 28 additions & 49 deletions demo/src/utils/wordList.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,69 +1,48 @@
import { parseString, WhitespaceHandling } from './wordList';

interface TestCase {
delimiter: string;
inputString: string;
}

const { Preserve, TrimLeadingAndTrailing } = WhitespaceHandling;

describe('parseString', () => {
it('returns an empty array when input string is empty', () => {
function testInput(input: string): void {
const wordList = parseString(input, ',', Preserve);
it.each(['', null, undefined])(
'returns an empty array when input string is %p',
input => {
const wordList = parseString(input as string, ',', Preserve);
expect(wordList).toEqual([]);
}
);

['', null, undefined].forEach(val => testInput(val as string));
});

it('returns entire input string in array when delimiter is empty', () => {
function testDelimiter(delimiter: string): void {
it.each(['', null, undefined])(
'returns entire input string in array when delimiter is %p',
testDelimiter => {
const delimiter = testDelimiter as string;
const wordList = parseString(' some input string ', delimiter, Preserve);
expect(wordList).toEqual([' some input string ']);
}
);

['', null, undefined].forEach(val => testDelimiter(val as string));
});

it('returns entire input string in array when delimiter is not present in input string', () => {
function testDelimiter(delimiter: string): void {
it.each([',', '\n', '\t'])(
'returns entire input string in array when delimiter %p is not present in input string',
delimiter => {
const wordList = parseString(' some input string ', delimiter, Preserve);
expect(wordList).toEqual([' some input string ']);
}

[',', '\n', '\t'].forEach(testDelimiter);
});

it('splits input string by delimiter', () => {
const expectedResult = ['foo', 'Bar', ' b@z '];
const testCases: TestCase[] = [
{ delimiter: ',', inputString: 'foo,Bar, b@z ' },
{ delimiter: '\t', inputString: 'foo Bar b@z ' },
{ delimiter: 'aaa', inputString: 'fooaaaBaraaa b@z ' },
];

function testSplit({ delimiter, inputString }: TestCase): void {
const wordList = parseString(inputString, delimiter, Preserve);
expect(wordList).toEqual(expectedResult);
}

testCases.forEach(testSplit);
);

it.each([
['foo,Bar, b@z ', ','],
['foo Bar b@z ', '\t'],
['fooaaaBaraaa b@z ', 'aaa'],
])('splits input string %p by delimiter %p', (inputString, delimiter) => {
const wordList = parseString(inputString, delimiter, Preserve);
expect(wordList).toEqual(['foo', 'Bar', ' b@z ']);
});

it('splits input string by whitespace delimiter', () => {
const expectedResult = ['foo', 'Bar', 'b@z', ''];
const testCases: TestCase[] = [
{ delimiter: ' ', inputString: 'foo Bar b@z ' },
{ delimiter: ' ', inputString: 'foo Bar b@z ' },
];

function testSplit({ delimiter, inputString }: TestCase): void {
const wordList = parseString(inputString, delimiter, Preserve);
expect(wordList).toEqual(expectedResult);
}

testCases.forEach(testSplit);
it.each([
['foo Bar b@z ', ' '],
['foo Bar b@z ', ' '],
])('splits input string %p by delimiter %p', (inputString, delimiter) => {
const wordList = parseString(inputString, delimiter, Preserve);
expect(wordList).toEqual(['foo', 'Bar', 'b@z', '']);
});

it('splits multiline input string by newline delimiter', () => {
Expand Down
6 changes: 2 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
"@types/jest-when": "^2.7.0",
"@typescript-eslint/eslint-plugin": "^2.2.0",
"@typescript-eslint/parser": "^2.2.0",
"codecov": "^3.6.1",
"eslint": "6.1.0",
"eslint-config-airbnb-base": "14.0.0",
"eslint-config-prettier": "^6.3.0",
Expand All @@ -61,12 +60,11 @@
"eslint-plugin-jest": "^22.17.0",
"husky": "^0.14.3",
"jest": "^26.0.0",
"jest-when": "^2.7.0",
"jest-when": "^3.1.0",
"npm-run-all": "^4.1.5",
"prettier": "^1.13.7",
"pretty-quick": "^1.6.0",
"regenerator-runtime": "^0.13.3",
"regex-to-strings": "^1.0.0",
"regex-to-strings": "^2.0.1",
"rimraf": "^2.6.2",
"ts-jest": "^26.4.4",
"ts-loader": "^6.1.0",
Expand Down
2 changes: 0 additions & 2 deletions src/utils/pattern.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'regenerator-runtime/runtime';

import { expandAll } from 'regex-to-strings';
import { CharTrie } from '../types/charTrie';
import { build } from './pattern';
Expand Down