Skip to content

Conversation

@arnonuem
Copy link

@arnonuem arnonuem commented Nov 8, 2018

changed parameter name of windturbine to turbine_name

Contributor Agreement

changed parameter name of windturbine to turbine_name
fixed another occurance of 'name'
@uvchik
Copy link
Member

uvchik commented Nov 12, 2018

I wonder why you have opened two PR with the same content.

In the actual dev-branch the attribute is named name.
https://github.com/wind-python/windpowerlib/blob/dev/windpowerlib/wind_turbine.py#L24

Maybe you use an old version of the windpowerlib but took the example from the actual branch?

The solution should be to make a release soon with everything in line.

@SabineHaas
Copy link
Member

uvchik is right: if you install the windpowerlib via pip (or use the master-branch) you have to use the example of the master-branch where the attribute is still named turbine_name.

You might have gotten the example from the latest version of the documentation (https://windpowerlib.readthedocs.io/en/latest/ ) where we link the dev-branch examples.
The examples matching the the master-branch are linked in the stable documentation (https://windpowerlib.readthedocs.io/en/stable/).

I adjusted the links in the github readme of the master-branch to lead to the stable version of readthedocs.

@uvchik
Copy link
Member

uvchik commented Nov 13, 2018

I still think we should release soon, the dev branch is about 300 commits ahead.

@arnonuem Thank you anyway for your effort but I think we can close this unmerged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants