-
Notifications
You must be signed in to change notification settings - Fork 855
feat: add inkeep endpoint #5845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 2fab5c3 in 38 seconds. Click for details.
- Reviewed
38lines of code in3files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. backend/ee-repo-ref.txt:1
- Draft comment:
Updated commit hash. Ensure this update is intentional and that all dependent services are compatible with it. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. backend/windmill-api/src/inkeep_ee.rs:3
- Draft comment:
The new inkeep endpoint is currently a placeholder returning an empty router. Consider adding documentation or preliminary routes to clarify its intended future functionality. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. backend/windmill-api/src/lib.rs:583
- Draft comment:
The /inkeep route is added similarly to other endpoints. Confirm that it does not require additional middleware (e.g., auth or CORS) if needed for consistent security and behavior. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_B0A7OpZFWlz1ycAu
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 25c8e6e in 34 seconds. Click for details.
- Reviewed
8lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. backend/ee-repo-ref.txt:1
- Draft comment:
Added trailing newline for consistency. This adheres to best practices. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_BrUlGsgXvvYq9OP9
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Important
Add
/inkeependpoint with conditional private feature handling inlib.rsandinkeep_oss.rs./inkeependpoint to the server inrun_server()inlib.rs.inkeep_ee::global_service()for private feature, otherwise usesRouter::new().mod inkeep_eeandmod inkeep_ossinlib.rs.inkeep_oss.rswith conditional compilation for private and non-private features.This description was created by
for 25c8e6e. You can customize this summary. It will automatically update as commits are pushed.