chore: rearrange .env files#49
Conversation
timmyichen
left a comment
There was a problem hiding this comment.
Thanks for making this change!
MainlyColors
left a comment
There was a problem hiding this comment.
LGTM
Documenting Thoughts:
Thought we needed docker-compose.test.yml file but looks like when no -f option is given to docker-compose then docker will look for the default docker-compose.yml file and we were already creating a new test DB with the createDb() method in server/test/server.ts TestServer class so there is no reason to have separate docker-compose.test.yml file as it wasn't being used
ah it's being used in the github action here I think @MatthewBozin might remember better why exactly it was needed but I remember it breaking with the default docker-compose |
Caleb-Cohen
left a comment
There was a problem hiding this comment.
LGTM, Devon never does wrong.
Closes N/A
Description
We were operating under the understanding that the
.env.<environment>files set the defaults for each environment and the.envfile would override. Based on dotenv-flow's documentation, that is the opposite of how it works.This change introduces a
.env.defaultsto initialize default values, users are still instructed to create a.envfor configuring secrets, and the environment-specific.env.<environment>files will have the highest priority and overwrite all other files.Testing
Ensure that the project starts and the tests still pass.
Type of change
Please remove all except for everything applicable, and then remove this line.
Screenshots
N/A
Checklist: