Api all users#65
Merged
Merged
Conversation
Caleb-Cohen
requested review from
DevinCLane,
MainlyColors,
MatthewBozin,
code2244,
dev-skworks,
devonzara,
intelagense,
jamiecha88,
jmoldyvan,
sstrunks52005,
timmyichen,
windyScripts and
wo1vin
as code owners
Caleb-Cohen
changed the base branch from
main
to
#33-remove-get-user-profile-endpoint
Caleb-Cohen
commented
Mar 26, 2023
Caleb-Cohen
left a comment
Caleb-Cohen
left a comment
Collaborator
Author
There was a problem hiding this comment.
added some comments
| } | ||
|
|
||
| export default createUser; | ||
| function getExpectedUserObject(user: User) { |
Collaborator
Author
There was a problem hiding this comment.
abstracted user compares for testing
Caleb-Cohen
force-pushed
the
apiAllUsers
branch
from
c223cec to
42f46b7
Compare
timmyichen
reviewed
Mar 26, 2023
timmyichen
left a comment
timmyichen
left a comment
Collaborator
There was a problem hiding this comment.
Mostly looks good, just left some comments about changes I think would be good
devonzara
reviewed
Mar 27, 2023
Caleb-Cohen
force-pushed
the
apiAllUsers
branch
from
de948c7 to
4044b3c
Compare
Caleb-Cohen
commented
Mar 28, 2023
| "docker:deps": "docker-compose up -d", | ||
| "heroku-postbuild": "npm run build && npx sequelize-cli db:migrate", | ||
| "jest": "cross-env NODE_ENV=test npx jest --runInBand", | ||
| "jest": "cross-env NODE_ENV=test npx jest --runInBand --forceExit", |
Collaborator
Author
There was a problem hiding this comment.
I could not get this to pass github actions testing without it. It would hang otherwise.
devonzara
requested changes
Mar 29, 2023
devonzara
left a comment
devonzara
left a comment
Collaborator
There was a problem hiding this comment.
Looks good for the most part, few minor changes I'd suggest...
devonzara
reviewed
Mar 29, 2023
Caleb-Cohen
force-pushed
the
apiAllUsers
branch
from
4044b3c to
9551ad4
Compare
Caleb-Cohen
force-pushed
the
apiAllUsers
branch
from
9551ad4 to
14e8beb
Compare
devonzara
approved these changes
Mar 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge until #33 is completed
Closes #57 (replace with issue number)
Description
Created endpoint that returns all users.
Abstracted user test
Testing
execute
npm run testType of change
Please remove all except for everything applicable, and then remove this line.
Screenshots
Please include any screenshots if there are visual changes.
Checklist: