add timeout to github actions#69
Merged
Merged
Conversation
Caleb-Cohen
requested review from
DevinCLane,
MainlyColors,
MatthewBozin,
code2244,
dev-skworks,
devonzara,
intelagense,
jamiecha88,
jmoldyvan,
sstrunks52005,
timmyichen,
windyScripts and
wo1vin
as code owners
MainlyColors
approved these changes
Mar 28, 2023
MainlyColors
left a comment
MainlyColors
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
I'm interested in why only 2 PRs ran for so long but this PR ran for the normal ~2mins like all others
Collaborator
|
Do we need 10 minutes? Seems like the ones that pass average about 2 minutes, I think 5 would be plenty for our current tests. We can adjust it in the future as they grow... |
Collaborator
Author
Request accepted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #issue-number-here (replace with issue number)
Description
I had two test hang and run for 15+ minutes today. This adds a timeout so we don't waste @timmyichen's money.
Testing
Describe what a reviewer should do to test your code, including instructions for manually testing as well as relevant automated test suites to run.
Type of change
Please remove all except for everything applicable, and then remove this line.
Screenshots
No
Checklist: