test: fix Jest issues#70
Merged
Merged
Conversation
fix issue preventing Jest from exiting (open handle) fix globals warning when running Jest convert Jest config to TypeScript
devonzara
requested review from
Caleb-Cohen,
DevinCLane,
MainlyColors,
MatthewBozin,
code2244,
dev-skworks,
intelagense,
jamiecha88,
jmoldyvan,
sstrunks52005,
timmyichen,
windyScripts and
wo1vin
as code owners
Collaborator
|
LGTM for two reasons
|
Caleb-Cohen
approved these changes
Mar 29, 2023
MainlyColors
approved these changes
Mar 29, 2023
MainlyColors
left a comment
MainlyColors
left a comment
Collaborator
There was a problem hiding this comment.
Your a wizard 🙇♂️🙇♂️🙇♂️
tests work on local
LGTM - Devon is never wrong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes N/A
Description
fix issue preventing Jest from exiting (open handle)
fix globals warning when running Jest
convert Jest config to TypeScript
Testing
Run
npm run test:serverConfirm that tests pass and that there isn't a
globalswarning before the tests executeConfirm that there isn't an
open handlewarning after the tests execute.Type of change
Please remove all except for everything applicable, and then remove this line.
Screenshots
Checklist: