Add Onboarding page and redirect from login via auth-redirect#82
Conversation
There was a problem hiding this comment.
From the created ticket:
Use MUI to create a new page where users are redirected to, after they log in.
Create a dismiss button that will redirect users to the dev-directory list of profiles page.
I took this to mean:
- When the user logs in, instead of redirecting to the index page, we send them to onboarding page
- When the user skips onboarding, they get sent to the home page (i left a comment on #59 around changing where the actual directory lives)
- If they refresh while on the home page, they are not prompted to go through onboarding again
This PR does the following:
- Anyone who lands on the home page, will be sent to the onboarding page
- When the user skips onboarding, they get sent back to the home page
- If they refresh while on the home page, they will be redirected to the onboarding page again
I think we may want to change this to be more like the former - when users log in via Discord, their code is validated on the auth-redirect page. This is probably where we want to be making changes related to redirecting to onboarding.
General nit: "onboarding" is one word, so any instances of "onBoarding" or "xOnBoarding" should probably just be changed to "onboarding" and "xOnboarding" respectively
devonzara
left a comment
There was a problem hiding this comment.
Looks good, just does a bit more than asked. Also, JSX should default to double quotes. 👍🏼
|
Oof, I wish the review page would update to show other reviewer comments as they post them like it does when there's a new commit... Tim hit on essentially all the same points; I could have been watching TV instead. 😅 |
|
I got caught up with some stuff, but I will look on my machine as soon as I can |
|
Also if we're switching to |
Thought I did that before because it changed on my end but I guess there is a specific git way to do a rename lol Fixed now |
devonzara
left a comment
There was a problem hiding this comment.
👍🏼 Few additional touch-ups.
|
nit: might be worth editing the PR's title, but otherwise looks good. 👍🏼 |
timmyichen
left a comment
There was a problem hiding this comment.
Mostly LGTM, just some small comments. Thanks for making the requested changes!
Closes #76
Description
/auth-redirectto/onboardinginstead of the previous//(temporary till/directoryexists )Testing
To Manually test
npm run dev:serverw/ docker already running/route/auth-redirect/auth-redirectroute after verifying the user is authorized via arouter.query.codeexisting, page will redirect to/onboardinginstead of the previous//(temporary till/directoryexists )Type of change
Screenshots
/onboarding/Checklist: