Restrict wildcard allowlist matching to anonymous callers#617
Merged
Conversation
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
*) entry as a global fallback after checking caller-specific rules, which allowed identified callers to match permissive wildcard rules and bypass per-caller restrictions.Description
findConstraintso wildcard rules are only considered when the request is anonymous (i.e.,callerID == "*"orcallerID == "").app/allowlist_test.goto reflect the intended semantics and add an assertion to prevent wildcard fallback for identified callers.Testing
go test ./app -run 'TestFindConstraint(Wildcard|ExpandsCallerAndWildcardCapabilities|ExpandsCapabilitiesOnLookup)$' -count=1and it passed.go test ./app -run 'TestAllowlist|TestConstraintFailureReasonHeader' -count=1and it passed.go test ./appwhich still fails in this environment due to a pre-existing unrelated test failureTestIntegrationPluginTransport(base transport mutated), so the failure is not caused by these changes.Codex Task