Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9590121db2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e5740e322a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Motivation
Description
redactConfigSourceto produce a redactedsrcand reference it inopenSourceerror messages instead of the rawpathand enhance messages to sayinvalid URL,request failed, orremote fetch ... failedwhere appropriate.redactSourceInErrorto replace occurrences of the raw source in underlying error text with the redacted source.redactConfigSourceparsing behavior to return the original input when URL parsing fails and keep a separate check for emptySchemeandHost.TestOpenSourceHTTPDialErrorRedactsSecretsand an additionalTestRedactConfigSourcecase for invalid URLs.Testing
go test ./...coveringopenSourceandredactConfigSourcebehavior.TestOpenSourceHTTPStatus,TestOpenSourceHTTPRequestError,TestOpenSourceHTTPDialErrorRedactsSecrets, andTestRedactConfigSource) passed successfully.Codex Task