Using assets combiner broke url(...)

[damsfx]

Winter CMS Build

dev-develop

PHP Version

8.1

Database engine

MySQL/MariaDB

Plugins installed

none

Issue description

When using assets combiner :

{{ [
    'assets/css/vendor.css',
    'assets/css/theme.css'
]|theme }}

If one of the assets contain a reference to a file with url(...) the reference get corrupted with backslash instead of slash.

This issue was detected on a Windows platform, which may be important given the difference in the use of slashes and backslashes.

Steps to replicate

In the demo theme, change :

<link href="{{ 'assets/css/vendor.css'|theme }}" rel="stylesheet">
<link href="{{ 'assets/css/theme.css'|theme }}" rel="stylesheet">

to :

<link href="{{ [
    'assets/css/vendor.css',
    'assets/css/theme.css'
]|theme }}" rel="stylesheet">

Reload site in FrontEnd, the Winter logo ha gone.

The reference to the link in the class definition is change
from : background-image: url('../images/winter.png');
to : background-image: url('../themes\demo\assets/images/winter.png');

What it is expected : background-image: url('../themes/demo/assets/images/winter.png');

Workaround

No response

[jaxwilko]

@damsfx could you try #898 and see if that resolves the issue?

[damsfx]

@damsfx could you try #898 and see if that resolves the issue?

@jaxwilko Not suffisent for me.

• Before : background-image: url('../themes\demo\assets/images/winter.png');
• After : background-image: url('../themes\demo/assets/images/winter.png');

The relative link to the asset still have a backslash between themes directory and the theme name.

[jaxwilko]

@damsfx thanks, just spent the last hour trying to get a windows VM set up to test on. I've pushed another commit that should fix the issue, but wont be able to test till this VM is set up

[damsfx]

@jaxwilko The issue no longer exists.
Note I'm not testing it on child themes.
Thank's.

If there is a need to do other tests under Windows, do not hesitate, I always have a machine dedicated to this task with the latest dev-develop version installed.

[jaxwilko]

@damsfx thank you very much for your efforts!