Fix/use ConfirmableTrait in winter env and add support for --force#1368
Merged
LukeTowers merged 2 commits intoJun 13, 2025
Merged
Conversation
LukeTowers
added
the
maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to align with the other winter console commands, I figured I would make use of the ConfirmableTrait.
I also noticed that the method I removed in favour of the ConfirmableTrait version had some code about the force option, but this force option didn't actually work, so I added force to the signature.
This change makes the code more consistent, and by using the ConfirmableTrait from Laravel, it just marginally reduces the amount of code the Winter team needs to maintain.