Trim the profile-completion checklist to three steps (#2001)

* Die Profil-Checkliste zeigt drei Schritte statt fünf

Der Tag-Schritt war für jeden neu Angemeldeten schon abgehakt, weil die
Registrierung drei Tags verlangt, und lehrte deshalb nichts; den Follow-Schritt
ersetzt die daneben stehende Karte „Wem folgen", die echte Gesichter zeigt,
statt bis fünf zu zählen. Der LinkedIn-Import rückt dafür von der Fußzeile in
die Liste: er füllt als einziger Eintrag mehrere Profilabschnitte auf einmal und
gilt als erledigt, sobald ein Beruf oder eine Ausbildung eingetragen ist, von
Hand genauso wie aus dem Archiv. Den Link zu den LinkedIn-Kontakten trägt
weiterhin die Karte „Wem folgen".

Die Liste wird jetzt nur noch für den Eigentümer innerhalb des Onboarding-
Fensters gebaut, nicht mehr bei jedem fremden Profilaufruf.

Diesen Text hat ein KI-Agent in meinem Namen geschrieben. Ich weiß, dass das
problematisch ist.

Claude-Session: https://claude.ai/code/session_01U7NgwBLboWUBQ5U6g3GJEk

* Die Checkliste springt zum Feld, nicht an den Seitenanfang

Die Einstellungsseite ist mehrere Bildschirme lang, und die Kurzbeschreibung
liegt weit unter dem Namen: „Kurzbeschreibung hinzufügen" landete deshalb oben
und ließ den Leser selbst suchen. Das Feld bekommt eine Sprungmarke wie das
Profilbild und das Titelbild sie längst haben (#avatar, #cover), und beide
Schritte der Checkliste tragen jetzt die Marke ihres eigenen Feldes. Der Test
prüft mit, dass die Marken auf dem Formular wirklich existieren, damit kein
Sprung ins Leere geht.

Diesen Text hat ein KI-Agent in meinem Namen geschrieben. Ich weiß, dass das
problematisch ist.

Claude-Session: https://claude.ai/code/session_01U7NgwBLboWUBQ5U6g3GJEk

* Kataloge über den vereinten Stand neu erzeugt

Der Rebase auf main traf in allen vier Katalogen auf Konflikte, weil #2000
gleichzeitig elf msgids für die Feed-Filter hinzugefügt hat. Statt die Hunks von
Hand aufzulösen steht hier mains Seite und darüber ein Lauf von
`mix gettext.extract --merge`, der die zwei msgids des Follow-Schritts entfernt.
Keine neuen fuzzy-Einträge.

Diesen Text hat ein KI-Agent in meinem Namen geschrieben. Ich weiß, dass das
problematisch ist.

Claude-Session: https://claude.ai/code/session_01U7NgwBLboWUBQ5U6g3GJEk

Author: wintermeyer

docs/architecture/settings-and-account.md

@@ -349,13 +349,19 @@ parsing and case-insensitive de-duplication the tag creation uses).
 
 After the confirmation PIN a fresh member lands on their own profile, where the
 **"Complete your profile" checklist** (owner-only, first hour after sign-up —
-`UserProfileLive.@onboarding_window_seconds`) opens with the tag step already
-checked — 1/5 done — and leads through photo → tagline (Kurzbeschreibung) →
-**first post** (suggesting a topic from the member's own tags, "Zum Beispiel
-ein Gedanke zu #elixir") → **"Follow 5 members"**. The follow step shows the
-running count as its hint, ticks off live when the fifth follow happens on the
-page itself, and links to the "Who to follow" card — or, on an installation
-with nobody to suggest, to the member directory.
+`UserProfileLive.@onboarding_window_seconds`) names three steps: photo →
+tagline (Kurzbeschreibung) → **"Import from LinkedIn"**. The import is the one
+step that fills several profile sections at once, which is why it is a step and
+not a link under the card; it counts as done once the profile carries a work
+experience or an education entry, so a member who types one in by hand is not
+left with a step they cannot finish.
+
+Three things are deliberately *not* on the list. A **tag** step, because
+sign-up already requires three tags, so it only ever arrived pre-checked. A
+**first post**, because it asks the one thing a member cannot do well in their
+first minute here, with nobody yet reading. And a **follow** step, because the
+promoted "Who to follow" card sits right beside the checklist with real faces
+on it, and a checkbox counting to five read as a quota.
 
 While the owner follows fewer than five members
 (`UserProfileLive.@discovery_follow_target`), the profile also renders the
@@ -373,11 +379,7 @@ then thinned by the per-viewer exclusions (owner, viewer, already-followed,
 blocked). Follower totals deliberately play no part — they reward the past,
 while the card's promise is a feed with something in it, which only current,
 liked output can keep. Deliberately strict, so a thin card beats a padded
-one; an installation with no recent posts renders no card, and the checklist
-step then links to the member directory instead.
-
-Work experience is deliberately not on the checklist; its section card keeps its
-own add tile.
+one; an installation with no recent posts renders no card.
 
 ## Username (@handle) changes
 

lib/vutuv_web/live/user_profile_live.ex

@@ -612,14 +612,7 @@ defmodule VutuvWeb.UserProfileLive do
         force: true
       )
 
-    socket
-    |> put_social_assigns(user, [])
-    # The follow step is the one checklist item completable on this very page
-    # (the promoted rail's follow buttons), so re-derive the steps and the tick
-    # lands live. The checklist's visibility and the rail's promoted spot stay
-    # as mounted; recomputing them here would yank the panel (or the card)
-    # away under the member's cursor on the fifth follow.
-    |> refresh_completion_steps()
+    put_social_assigns(socket, user, [])
   end
 
   # The follow-graph slice of the assigns, shared by the initial load and the
@@ -818,8 +811,8 @@ defmodule VutuvWeb.UserProfileLive do
   # ── Initial load (ports UserController.show_html) ──
 
   # The discovery threshold: the owner's own profile leads the rail with the
-  # promoted "Who to follow" card (and the checklist carries a follow step)
-  # until they follow at least this many members. Below it their feed is too
+  # promoted "Who to follow" card until they follow at least this many members.
+  # Below it their feed is too
   # empty to be worth visiting (Home.path even keeps them on the profile), so
   # discovery outranks their own detail cards.
   @discovery_follow_target 5
@@ -946,6 +939,15 @@ defmodule VutuvWeb.UserProfileLive do
         fn -> owner? && Vutuv.Posts.get_draft(current_user) end
       ])
 
+    # The onboarding checklist is the owner's alone and expires with the
+    # onboarding window, so a visitor's view — nearly every view of this page —
+    # skips building it. What is left of the gate (is anything still undone?)
+    # is the list itself, below.
+    checklist =
+      if owner? and not user.onboarding_dismissed? and onboarding_window?(user),
+        do: completion_steps(user, totals),
+        else: []
+
     socket
     |> assign(:as_owner?, owner?)
     |> ComposerPanel.open_for_draft(draft || nil)
@@ -999,20 +1001,13 @@ defmodule VutuvWeb.UserProfileLive do
       relationship: relationship,
       work_info: work_info
     )
-    # The rail promotion and the checklist's follow step both read the followee
-    # count put_social_assigns just computed. The promotion is deliberately set
-    # only here, never on the social-graph refresh: the fifth follow, made from
-    # the promoted rail itself, must not teleport the card to the bottom of the
-    # page under the member's cursor. The next visit demotes it.
-    |> then(
-      &assign(
-        &1,
-        :promote_discovery?,
-        owner? and &1.assigns.followee_count < @discovery_follow_target
-      )
-    )
-    |> refresh_completion_steps()
-    |> then(&assign(&1, :show_completion?, show_completion?(&1.assigns)))
+    # The rail promotion is deliberately set only here, never on the
+    # social-graph refresh: the fifth follow, made from the promoted rail
+    # itself, must not teleport the card to the bottom of the page under the
+    # member's cursor. The next visit demotes it.
+    |> assign(:promote_discovery?, owner? and social_counts.followees < @discovery_follow_target)
+    |> assign(:completion_steps, checklist)
+    |> assign(:show_completion?, Enum.any?(checklist, &(not &1.done)))
     |> put_social_feed_assigns(user)
     |> put_code_stats_assigns(user)
     |> put_job_search_assigns(user)
@@ -1454,86 +1449,56 @@ defmodule VutuvWeb.UserProfileLive do
     )
   end
 
-  # Re-derive the checklist from the current assigns; called from the initial
-  # load and from the social-graph refresh (the follow step's count changes
-  # live). Reads :followee_count, so it must run after put_social_assigns.
-  defp refresh_completion_steps(socket) do
-    %{user: user, followee_count: followee_count} = socket.assigns
-
-    assign(
-      socket,
-      :completion_steps,
-      completion_steps(user, followee_count, socket.assigns.recommended_users != [])
-    )
-  end
-
-  defp show_completion?(%{as_owner?: owner?, user: user, completion_steps: steps}) do
-    owner? and not user.onboarding_dismissed? and
-      Enum.any?(steps, &(not &1.done)) and onboarding_window?(user)
-  end
-
-  defp completion_steps(user, followee_count, suggestions?) do
+  defp completion_steps(user, totals) do
     [
-      # Sign-up requires three tags, so this step arrives already checked: the
-      # checklist opens with visible progress instead of a wall of zeros
-      # (people finish lists they have visibly started). It stays actionable
-      # for tag-less accounts from before the minimum, in their
-      # dormant-return window.
-      %{label: gettext("Add a tag"), done: user.user_tags != [], href: ~p"/settings/tags/new"},
       # Both land on /settings/profile, which is where the two fields actually
       # live. They used to point at /:slug/edit, the retired owner URL that only
       # redirects there — one wasted round trip, and a link that shows the old
-      # address in the status bar.
+      # address in the status bar. Each carries the fragment of its own field
+      # (the ids are in the form), so the step lands on the input rather than at
+      # the top of a page whose fields are several screens apart.
       %{
         label: gettext("Add a profile photo"),
         done: present?(user.avatar),
-        href: ~p"/settings/profile"
+        href: ~p"/settings/profile#avatar"
       },
       %{
         label: gettext("Add a tagline"),
         done: present?(user.headline),
-        href: ~p"/settings/profile"
+        href: ~p"/settings/profile#tagline"
       },
+      # The importer is a step of its own, not a footer link under the card: it
+      # is the one entry here that fills several profile sections in a single
+      # go, so it belongs where the eye already is. Done once the profile
+      # carries a career entry, which is what the archive brings — typing one in
+      # by hand counts just as much, so nobody without a LinkedIn account is
+      # left with a step they cannot finish.
+      %{
+        label: gettext("Import from LinkedIn"),
+        done: totals.jobs > 0 or totals.educations > 0,
+        href: ~p"/settings/import/linkedin"
+      }
       # There is deliberately NO "write your first post" step. It asked the one
       # thing a member cannot do well on their first minute here — they have
       # nobody reading yet and nothing to answer — and it is the step a new
       # account is least likely to complete, so the list ended on a dead end.
       # Posting has its own permanent invitation at the top of the Posts card
       # and on the feed; it does not need a checkbox.
-      # vutuv runs on following: the feed stays empty until the member follows
-      # people, so the list closes with the social step. Its link jumps to the
-      # "Who to follow" card, which the under-threshold owner view promotes to
-      # the top of the rail; an installation with nobody to suggest falls back
-      # to the browsable member directory instead of a dead anchor.
-      %{
-        # Deliberately no number in the label. "Follow 5 members" reads as a
-        # quota to be served, and the figure is ours, not the member's. The
-        # threshold below still decides when the step is done; the hint under it
-        # reports real progress, which is the encouraging half of a count.
-        label: gettext("Follow other members"),
-        done: followee_count >= @discovery_follow_target,
-        href: if(suggestions?, do: "#profile-who-to-follow", else: ~p"/system/members"),
-        hint: follow_step_hint(followee_count)
-      }
+      # There is no tag step either (sign-up already requires three, so it
+      # arrived checked off and taught nothing) and no follow step: the
+      # promoted "Who to follow" card beside the checklist is the invitation,
+      # with real faces on it, and a checkbox counting to five read as a quota.
     ]
   end
 
-  # Progress under the follow step ("You already follow 2 members."): visible
-  # momentum once the count has started, nothing at zero (the label alone
-  # reads cleaner) and nothing once the step is done.
-  defp follow_step_hint(n) when n < 1 or n >= @discovery_follow_target, do: nil
-
-  defp follow_step_hint(n),
-    do: ngettext("You already follow one member.", "You already follow %{count} members.", n)
-
   defp present?(nil), do: false
   defp present?(value) when is_binary(value), do: String.trim(value) != ""
   defp present?(_), do: true
 
   # The checklist is a brief, one-time post-registration nudge: it shows only
   # during the first hour after sign-up, then never again. A member who wants it
   # gone sooner closes it with the × (the dismiss_onboarding event sets
-  # users.onboarding_dismissed? for good — see the show_completion? gate above).
+  # users.onboarding_dismissed? for good — see the gate in load_profile/1).
   @onboarding_window_seconds 60 * 60
 
   defp onboarding_window?(user) do

lib/vutuv_web/templates/user/edit.html.heex

@@ -241,7 +241,15 @@ lands here). --%>
         trimmed enough — the server still validates the cap (error_tag below).
         The number is language-neutral; only the static "characters" word is
         translated, and it never pluralizes in the "N/255" form. --%>
-        <div data-char-counter data-max={Vutuv.Accounts.User.headline_max_length()}>
+        <%!-- id + scroll-mt: the onboarding checklist's tagline step links to
+        /settings/profile#tagline, so the member lands on the field instead of
+        the top of a long settings page (same as #avatar and #cover above). --%>
+        <div
+          id="tagline"
+          class="scroll-mt-24"
+          data-char-counter
+          data-max={Vutuv.Accounts.User.headline_max_length()}
+        >
           <%= label f, :headline, gettext("Tagline"), class: "block text-sm font-medium text-slate-900 dark:text-white" %>
           <%= textarea f, :headline, rows: 3, class: input_class(), data: [char_count_input: true] %>
           <div class="mt-1 flex items-start justify-between gap-3">

lib/vutuv_web/templates/user/show.html.heex

@@ -377,9 +377,7 @@ the resulting ~200px rail width. --%>
     the onboarding window (the first hour after sign-up) while anything is still
     undone, and gone once every step is done or the owner closes it with the ×
     (which persists, so it stays gone); @show_completion? carries that gate (see
-    UserProfileLive). Each todo links straight to where it is done. The tag step
-    is already checked for anyone registered since the three-tag sign-up minimum,
-    so the list opens with visible progress. --%>
+    UserProfileLive). Each todo links straight to where it is done. --%>
     <section
       :if={@show_completion?}
       id="profile-completion"
@@ -416,10 +414,7 @@ the resulting ~200px rail width. --%>
         <div class="h-full rounded-full bg-brand-600 transition-all" style={"width: #{round(done_count / total * 100)}%"}></div>
       </div>
       <ul class="mt-4 space-y-2">
-        <%!-- items-start (not center): a step may carry a one-line hint under
-        its label, and the glyph should stay on the label line. text-sm lines
-        and the h-5 glyphs are both 20px, so the first lines still align. --%>
-        <li :for={step <- @completion_steps} class="flex items-start gap-3">
+        <li :for={step <- @completion_steps} class="flex items-center gap-3">
           <%= if step.done do %>
             <span class="flex h-5 w-5 shrink-0 items-center justify-center rounded-full bg-brand-600 text-white" aria-hidden="true">
               <svg class="h-3 w-3" fill="none" stroke="currentColor" stroke-width="3" viewBox="0 0 24 24">
@@ -429,43 +424,12 @@ the resulting ~200px rail width. --%>
             <span class="text-sm text-brand-700/50 line-through dark:text-brand-200/40">{step.label}</span>
           <% else %>
             <span class="h-5 w-5 shrink-0 rounded-full border-2 border-brand-300 dark:border-brand-700" aria-hidden="true"></span>
-            <span class="min-w-0">
-              <.link href={step.href} class="text-sm font-medium text-brand-800 hover:underline dark:text-brand-100">
-                {step.label}
-              </.link>
-              <%!-- The optional per-step nudge (the first-post topic borrowed
-              from the member's own tags) — quiet, muted, not a second link. --%>
-              <span :if={step[:hint]} class="block text-xs text-brand-700/70 dark:text-brand-200/60">
-                {step.hint}
-              </span>
-            </span>
+            <.link href={step.href} class="text-sm font-medium text-brand-800 hover:underline dark:text-brand-100">
+              {step.label}
+            </.link>
           <% end %>
         </li>
       </ul>
-
-      <%!-- A quiet link into the LinkedIn importer: the fastest way to fill
-      several of the steps above at once. Owner-only (it lives inside this
-      owner-only card) and part of the same onboarding push. --%>
-      <div class="mt-4 space-y-1 border-t border-brand-100 pt-4 dark:border-brand-900/50">
-        <.link
-          navigate={~p"/settings/import/linkedin"}
-          class="inline-flex items-center gap-1 text-sm font-semibold text-brand-800 hover:underline dark:text-brand-100"
-        >
-          {gettext("Import from LinkedIn")}
-          <span aria-hidden="true">→</span>
-        </.link>
-        <%!-- The other thing that same archive is good for (issue #1476), and
-        the fastest way through the "follow other members" step above: the
-        people you already know are better company than any suggestion we can
-        make on a member's first minute here. --%>
-        <.link
-          navigate={~p"/settings/import/linkedin/connections"}
-          class="flex items-center gap-1 text-sm font-semibold text-brand-800 hover:underline dark:text-brand-100"
-        >
-          {gettext("Find people you know from LinkedIn")}
-          <span aria-hidden="true">→</span>
-        </.link>
-      </div>
     </section>
 
     <%!-- Posts (latest visible to this viewer; the owner writes them right here,

lib/vutuv_web/views/user_html.ex

@@ -226,10 +226,13 @@ defmodule VutuvWeb.UserHTML do
 
   def who_to_follow_card(assigns) do
     ~H"""
+    <%!-- The card's scroll-mt-24 went with the checklist's follow step: it
+    existed so that step's #profile-who-to-follow jump did not land under the
+    top bar, and nothing links to the anchor any more. --%>
     <.card
       :if={@recommended_users != []}
       id="profile-who-to-follow"
-      class={if(@promoted, do: "scroll-mt-24", else: "scroll-mt-24 order-1 md:order-none")}
+      class={if !@promoted, do: "order-1 md:order-none"}
       data-promoted={@promoted}
     >
       <.section_title class="mb-4">{gettext("Who to follow")}</.section_title>