Skip to content

fix(memory-core): yield to event loop during seedEmbeddingCache (R2.A.2) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesaai merged 2 commits into from
Apr 24, 2026
Merged

fix(memory-core): yield to event loop during seedEmbeddingCache (R2.A.2) #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9e9970
fix(memory-core): yield to event loop during seedEmbeddingCache iterate
lesaai Apr 24, 2026
675e54d
fix(memory-core): remove misleading lint-comment churn from R2.A.2
lesaai Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions extensions/memory-core/src/memory/manager-sync-ops.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ export abstract class MemoryManagerSyncOps {
return openMemoryDatabaseAtPath(dbPath, this.settings.store.vector.enabled);
}

private seedEmbeddingCache(sourceDb: DatabaseSync): void {
private async seedEmbeddingCache(sourceDb: DatabaseSync): Promise<void> {
if (!this.cache.enabled) {
return;
}
Expand Down Expand Up @@ -323,6 +323,9 @@ export abstract class MemoryManagerSyncOps {
updated_at=excluded.updated_at`,
);
this.db.exec("BEGIN");
// Yield to event loop every N rows so HTTP /health probes stay responsive.
const SEED_EMBEDDING_YIELD_EVERY = 1000;
let rowCount = 0;
for (const row of rows) {
insert.run(
row.provider,
Expand All @@ -333,6 +336,12 @@ export abstract class MemoryManagerSyncOps {
row.dims,
row.updated_at,
);
rowCount += 1;
if (rowCount % SEED_EMBEDDING_YIELD_EVERY === 0) {
await new Promise<void>((resolve) => {
setImmediate(resolve);
});
}
}
this.db.exec("COMMIT");
} catch (err) {
Expand Down Expand Up @@ -1160,7 +1169,7 @@ export abstract class MemoryManagerSyncOps {
targetPath: dbPath,
tempPath: tempDbPath,
build: async () => {
this.seedEmbeddingCache(originalDb);
await this.seedEmbeddingCache(originalDb);
const shouldSyncMemory = this.sources.has("memory");
const shouldSyncSessions = this.shouldSyncSessions(
{ reason: params.reason, force: params.force },
Expand Down
Loading