Feature/stab fixes sessions flows#12
Merged
Merged
Conversation
- fixes claude mapper
roxblnfk
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and bug fixes to the Claude and OpenAI mappers, as well as updates to the Stream module documentation. The most significant changes include stricter tool ID sanitization and handling for Claude integration, improved merging logic for developer messages, a more robust approach to empty function call arguments in the OpenAI mapper, and a comprehensive rewrite of the Stream module's documentation to clarify its API and behavior.
Claude Mapper Improvements:
sanitize_tool_idfunction to enforce Claude's tool ID format and applied it wherever tool IDs are set or read, preventing invalid tool IDs from causing errors. [1] [2] [3] [4] [5]OpenAI Mapper Fixes:
{}by replacing them with{ invoke = true }, ensuring downstream compatibility.Documentation Updates:
Streammodule documentation to clarify its API, including chunk-based and token-based reading, scanner lifecycle, async behavior, error handling, and best practices. This makes the module's usage and expected behaviors much clearer for developers. [1] [2]Minor/Other:
fromPID in the message processing spec for completeness.