Skip to content

Feature/stabilization and simplication#9

Merged
roxblnfk merged 6 commits into
mainfrom
feature/stabilization-and-simplication
Sep 16, 2025
Merged

Feature/stabilization and simplication#9
roxblnfk merged 6 commits into
mainfrom
feature/stabilization-and-simplication

Conversation

@wolfy-j

@wolfy-j wolfy-j commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

This pull request introduces several improvements and refactorings to session management, operation processing, and configuration handling in the codebase. The most significant changes include enhanced tracking of pending operations in the command bus, more robust and informative handling of agent/model configuration changes, streamlined session status updates, and improved handling of private tool calls. Additionally, the plugin initialization logic has been cleaned up for better readability.

Operation processing and session status:

  • Added pending_ops tracking to the command_bus to accurately monitor the number of queued and processed operations, and trigger a callback when the queue is empty. [1] [2] [3] [4]
  • Updated session status in the database upon session termination, and ensured status updates are sent upstream before session closed notifications.

Configuration and agent/model switching:

  • Refactored control_config to handle agent and model changes more robustly, including switching agents/models as needed, updating upstream session state, and adding detailed system/developer messages about configuration changes. [1] [2]

Message and tool operation handling:

  • Improved tool call handling to support marking certain tool calls as private, preventing their results from being sent upstream, and ensuring correct status reporting. [1] [2] [3] [4]
  • Simplified status updates and completion logic in message and tool handlers, removing redundant status updates and making completion state explicit. [1] [2] [3]

Plugin and session initialization cleanup:

  • Removed redundant comments and clarified logic in the plugin session and context creation flow, improving maintainability and readability. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

Operation processing and status

  • Added pending_ops field and logic in command_bus.lua to track operations and trigger a callback when the operation queue is empty. [1] [2] [3] [4]
  • Updated plugin to set session status in the database on termination and send status updates upstream before closing notifications.

Configuration changes and agent/model switching

  • Enhanced control_config to robustly handle agent/model changes, including switching logic, upstream updates, and system/developer messages with change details. [1] [2]

Message and tool handling

  • Improved tool call handling to support private tool calls, preventing their results from being sent upstream. [1] [2] [3] [4]
  • Simplified and clarified status/completion logic in message and tool handlers, removing redundant updates. [1] [2] [3]

Plugin/session initialization cleanup

@wolfy-j wolfy-j requested a review from roxblnfk September 15, 2025 20:33
@roxblnfk roxblnfk merged commit 18b63ec into main Sep 16, 2025
@roxblnfk roxblnfk deleted the feature/stabilization-and-simplication branch September 16, 2025 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants