Skip to content

feat: "add participants" button available for group admins [AR-1016]#760

Merged
saleniuk merged 4 commits into
developfrom
feat/add-members-btn-for-admin
Jul 12, 2022
Merged

feat: "add participants" button available for group admins [AR-1016]#760
saleniuk merged 4 commits into
developfrom
feat/add-members-btn-for-admin

Conversation

@saleniuk

@saleniuk saleniuk commented Jul 12, 2022

Copy link
Copy Markdown
Contributor
StoryAR-1016 Add Participants to Group Conversations


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

If I am a group admin then I should be able to add participants - the button should be available only for admins.

Solutions

Added "add participants" button to the participants tab with the logic to only show it if I am an admin.

Testing

How to Test

Open the options of a group conversation in which you are an admin.

Attachments (Optional)

Screenshot_20220712_131159


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions

github-actions Bot commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

Unit Test Results

  29 files  ±0    29 suites  ±0   25s ⏱️ -6s
166 tests ±0  166 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit a01bc00. ± Comparison against base commit ca24fd4.

♻️ This comment has been updated with latest results.

@AndroidBob

Copy link
Copy Markdown
Collaborator

Build 2 succeeded.

The build produced the following APK's:

@codecov

codecov Bot commented Jul 12, 2022

Copy link
Copy Markdown

Codecov Report

Merging #760 (a01bc00) into develop (ca24fd4) will increase coverage by 0.00%.
The diff coverage is 20.83%.

@@            Coverage Diff             @@
##             develop     #760   +/-   ##
==========================================
  Coverage      15.08%   15.08%           
  Complexity       328      328           
==========================================
  Files            229      229           
  Lines           9892     9904   +12     
  Branches        1628     1630    +2     
==========================================
+ Hits            1492     1494    +2     
- Misses          8268     8278   +10     
  Partials         132      132           
Impacted Files Coverage Δ
...ails/participants/GroupConversationParticipants.kt 0.00% <0.00%> (ø)
...ecase/ObserveParticipantsForConversationUseCase.kt 92.85% <ø> (ø)
...participants/GroupConversationParticipantsState.kt 90.90% <100.00%> (+0.90%) ⬆️
...participants/model/ConversationParticipantsData.kt 100.00% <100.00%> (ø)

@trOnk12 trOnk12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeeeey let's go

@AndroidBob

Copy link
Copy Markdown
Collaborator

Build 4 succeeded.

The build produced the following APK's:

@saleniuk saleniuk merged commit 7d9f8b3 into develop Jul 12, 2022
@saleniuk saleniuk deleted the feat/add-members-btn-for-admin branch July 12, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants