feat(logout): handle session expiration (AR-1556)#777
Merged
Conversation
8 tasks
Collaborator
|
Build 1 failed. |
…oaded into feat/AR-1656_handle_session_expiration � Conflicts: � app/src/main/kotlin/com/wire/android/ui/WireActivityViewModel.kt � kalium
Contributor
Collaborator
|
Build 2 failed. |
…oaded into feat/AR-1656_handle_session_expiration � Conflicts: � app/src/main/res/values/strings.xml � kalium
Collaborator
|
Build 3 failed. |
…oaded into feat/AR-1656_handle_session_expiration
Collaborator
|
Build 4 failed. |
Collaborator
|
Build 10 failed. |
…oaded into feat/AR-1656_handle_session_expiration � Conflicts: � .github/workflows/check-kalium-commitish.yml � kalium
Collaborator
|
Build 11 failed. |
Collaborator
|
Build 12 failed. |
Collaborator
|
Build 13 failed. |
Collaborator
|
Build 14 failed. |
MohamadJaara
requested changes
Aug 1, 2022
Member
MohamadJaara
left a comment
There was a problem hiding this comment.
🍇 work 🚀, only small changes needed to remove unnecessary assisted injection
...otlin/com/wire/android/notification/broadcastreceivers/SummaryNotificationDismissReceiver.kt
Show resolved
Hide resolved
…oaded into feat/AR-1656_handle_session_expiration
Collaborator
|
Build 16 failed. |
MohamadJaara
approved these changes
Aug 1, 2022
Collaborator
|
Build 17 succeeded. The build produced the following APK's: |
Codecov Report
@@ Coverage Diff @@
## develop #777 +/- ##
=============================================
+ Coverage 15.29% 15.34% +0.04%
+ Complexity 372 365 -7
=============================================
Files 241 240 -1
Lines 11033 11050 +17
Branches 1792 1801 +9
=============================================
+ Hits 1688 1696 +8
- Misses 9186 9192 +6
- Partials 159 162 +3
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
This PR cover 3 topics around user session:
In both above events + the selfLogout we need to send the reason of the logout to the AR app! So I had to refactor the AuthSession to support that idea.
Issues
Causes (Optional)
The events weren't handled before.
Solutions
Handle the events in the userEventsReceiver and refactor the AuthSession
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Needs to release Kalium related PR as well.
wireapp/kalium#661
Testing
Test Coverage (Optional)
WIP
How to Test
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.