Skip to content

fix: multithreading violation when inserting a message on degraded conversation#445

Merged
johnxnguyen merged 1 commit intofeat/mlsfrom
fix/thread-violation
Aug 31, 2023
Merged

fix: multithreading violation when inserting a message on degraded conversation#445
johnxnguyen merged 1 commit intofeat/mlsfrom
fix/thread-violation

Conversation

@johnxnguyen
Copy link
Collaborator

…nversation


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When inserting a message on a degraded MLS conversation, the app crashes.

Causes

A log statement uses self.nonce which belongs to another context (view) than the one it's currently on (sync).

Solutions

Use the nonce property from the object from the sync context.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

Test Results

       1 files   -        8     226 suites   - 711   12m 7s ⏱️ - 22m 38s
2 328 tests  - 5 549  2 328 ✔️  - 5 549  0 💤 ±0  0 ±0 
2 328 runs   - 5 560  2 328 ✔️  - 5 560  0 💤 ±0  0 ±0 

Results for commit 5705c8e. ± Comparison against base commit fb28393.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/thread-violation
Commit report: b7ed8d1

wire-ios-mono: 0 Failed, 0 New Flaky, 2328 Passed, 0 Skipped, 1m 19.25s Wall Time

@johnxnguyen johnxnguyen merged commit 73d4182 into feat/mls Aug 31, 2023
@johnxnguyen johnxnguyen deleted the fix/thread-violation branch August 31, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants