fix: multithreading violation when inserting a message on degraded conversation#445
Merged
johnxnguyen merged 1 commit intofeat/mlsfrom Aug 31, 2023
Merged
fix: multithreading violation when inserting a message on degraded conversation#445johnxnguyen merged 1 commit intofeat/mlsfrom
johnxnguyen merged 1 commit intofeat/mlsfrom
Conversation
netbe
approved these changes
Aug 31, 2023
Datadog ReportBranch report: ✅ |
David-Henner
approved these changes
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nversation
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When inserting a message on a degraded MLS conversation, the app crashes.
Causes
A log statement uses
self.noncewhich belongs to another context (view) than the one it's currently on (sync).Solutions
Use the
nonceproperty from the object from the sync context.PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.