Conversation
- new features/items module w/ list + get - extend features/spaces w/ router, service, count-aware repo methods - app shell nav at components/app-shell - quick capture composer (note/url/file) replaces verification shell - item detail view w/ blob, segments, derived memories - ask panel: real token streaming via streamGroundedAnswer - reorder ask status yields; drop post-hoc phases - pin wxt dev server to 3010 so extension stops racing next Completes LAB-126
item delete soft-deletes source+segments+orphan memories and removes S3 blob. account export emits versioned JSON manifest w/ presigned blob URLs. account delete hard-deletes all live data, blobs, and user. privacy page + settings updated w/ 30d backup retention wording. Completes LAB-127
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds end-user “data ownership” flows to the web app (source deletion, full account export, and account deletion) while expanding the authenticated shell with Spaces + Ask surfaces and upgrading query answering to stream responses.
Changes:
- Introduces oRPC routers + services for spaces, items (incl. deletion), and account export/deletion, plus corresponding UI in the app shell.
- Adds
/api/account/exportendpoint emitting a versioned JSON manifest with presigned blob download URLs. - Updates query answering to stream model output deltas to the client UI.
Reviewed changes
Copilot reviewed 45 out of 46 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/web/src/rpc/router.ts | Registers new account, items, and spaces routers. |
| apps/web/src/lib/ai/query.ts | Adds streamGroundedAnswer() using streamText. |
| apps/web/src/features/spaces/service.ts | Space list/get service layer. |
| apps/web/src/features/spaces/schemas.ts | Zod schemas for space list/detail. |
| apps/web/src/features/spaces/router.ts | oRPC procedures for spaces. |
| apps/web/src/features/spaces/repository.ts | Adds “with counts” queries for spaces. |
| apps/web/src/features/spaces/index.ts | Exports space UI/types. |
| apps/web/src/features/spaces/components/space-list-card.tsx | UI card for listing spaces. |
| apps/web/src/features/query/service.ts | Streams answer deltas from AI to event generator. |
| apps/web/src/features/query/service.test.ts | Updates mocks/tests for streamed answering + phase change. |
| apps/web/src/features/query/index.ts | Exports AskPanel. |
| apps/web/src/features/query/components/ask-panel.tsx | Client UI for ask-with-citations + streaming deltas. |
| apps/web/src/features/items/service.ts | Item list/get + delete orchestration (DB + storage cleanup). |
| apps/web/src/features/items/service.test.ts | Tests for item deletion behavior (happy + cleanup failure + NOT_FOUND). |
| apps/web/src/features/items/schemas.ts | Zod schemas for item list/detail + delete. |
| apps/web/src/features/items/router.ts | oRPC procedures for items. |
| apps/web/src/features/items/repository.ts | DB access for items list/detail + transactional soft-delete. |
| apps/web/src/features/items/index.ts | Exports item UI/types. |
| apps/web/src/features/items/components/item-preview-card.tsx | UI preview card for inbox listings. |
| apps/web/src/features/items/components/item-link.tsx | Shared link component to item detail. |
| apps/web/src/features/items/components/item-detail-view.tsx | Item detail UI including delete danger zone. |
| apps/web/src/features/items/components/inbox-list.tsx | List UI wrapper with empty state. |
| apps/web/src/features/items/components/delete-item-button.tsx | Client confirm-to-delete button for items. |
| apps/web/src/features/captures/index.ts | Switches exports to QuickCaptureComposer. |
| apps/web/src/features/captures/components/quick-capture-composer.tsx | Unified note/url/file capture UI. |
| apps/web/src/features/captures/components/capture-verification-card.tsx | Removes older capture verification UI. |
| apps/web/src/features/account/service.ts | Implements export manifest + account deletion + S3 cleanup. |
| apps/web/src/features/account/service.test.ts | Tests for export manifest + deletion cleanup behavior. |
| apps/web/src/features/account/schemas.ts | Zod schema for export manifest + delete output. |
| apps/web/src/features/account/router.ts | oRPC procedures for export + delete. |
| apps/web/src/features/account/repository.ts | Loads export data + transactional hard-delete logic. |
| apps/web/src/features/account/index.ts | Exports account settings UI/types. |
| apps/web/src/features/account/components/account-export-card.tsx | Settings UI to download export. |
| apps/web/src/features/account/components/account-danger-zone-card.tsx | Settings UI to delete account with confirmation phrase. |
| apps/web/src/components/app-shell/app-shell-nav.tsx | Adds app shell navigation. |
| apps/web/src/app/privacy/page.tsx | Updates privacy policy wording for export/deletion/retention. |
| apps/web/src/app/app/(shell)/spaces/page.tsx | Spaces index page. |
| apps/web/src/app/app/(shell)/spaces/[spaceId]/page.tsx | Space detail page (items in space). |
| apps/web/src/app/app/(shell)/settings/page.tsx | Settings page wiring export + delete account UIs. |
| apps/web/src/app/app/(shell)/page.tsx | Replaces prior internal surface with inbox + quick capture. |
| apps/web/src/app/app/(shell)/layout.tsx | Updates shell header/nav layout. |
| apps/web/src/app/app/(shell)/items/[sourceItemId]/page.tsx | Item detail page. |
| apps/web/src/app/app/(shell)/ask/page.tsx | Ask page wiring AskPanel. |
| apps/web/src/app/api/account/export/route.ts | New API route returning export manifest as downloadable JSON. |
| apps/web/next-env.d.ts | Updates Next-generated TS routes import path. |
| apps/extension/wxt.config.ts | Pins extension dev server origin/port. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dubscode
deleted the
feature/lab-127-implement-export-account-deletion-and-data-ownership-flows
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
items.deleteoRPC procedure soft-deletes the source, its segments, its blobs, and any memories that only cited it, then removes the S3 objects. Wired into item detail as a confirm-to-delete button.features/accountmodule emitting a versioned (v1) JSON manifest w/ user, spaces, source items, blobs, segments, memories, citations, device tokens. Live blobs get 15m presigned download URLs so the vault is reconstructable offline. Exposed via/api/account/exportand anAccountExportCardin Settings.account.deleteprocedure transactionally hard-deletes memory_citations → memories → ingestion_jobs → evaluation_runs → segments → source_blobs → source_items → spaces → user (cascades session / device_tokens / connector_cursors / account), followed by S3 blob cleanup and sign-out. Gated behind aDELETEconfirmation in the Settings danger zone.Completes LAB-127.
Note on scope
This PR is stacked on top of the LAB-126 commit (
457e04a feat(web): build inbox, spaces, item detail, ask, settings surfaces) because no PR was opened for LAB-126 yet. Please merge/rebase accordingly if LAB-126 ships in its own PR first.Test plan
pnpm qc— biome, typecheck, vitest (110 passing incl. 8 new), and web build all greendeleteItem(happy, blob failure, NOT_FOUND)exportAccount/deleteAccount(manifest shape, soft-deleted blobs get null URL, presign failure, NOT_FOUND, deletion happy / blob failure)/, confirm re-login creates a fresh empty vaultUnresolved questions