Quality polish: DRY, bug fixes, step summaries, dep bumps

[dcbickfo]

Summary

• DRY: Extract duplicated branch/commit-info logic into common/branch-info composite action, reuse across all actions
• Bug fixes: Harden shell scripts with set -eu, fix incorrect variable references, safer parameter defaults
• Step summaries: Add $GITHUB_STEP_SUMMARY markdown tables to Go build, test, lint, smoke-test, and deploy actions for at-a-glance CI results
• Dependency bumps: actions/setup-node@v3 → v4, node-version: 16 → 20; slackapi/slack-github-action@v1.24.0 → v1.27.1
• Cleanup: Remove dead sonarqube-scan action

No breaking changes — all new inputs are optional with backward-compatible defaults.

Validated on consuming repos

Repo	PR	CI	Staging Deploy
inventory-api (Go)	#14	pass	pass
geo-admin (Ruby)	#394	pass	pass

Files changed

• New: common/branch-info/action.yml — shared branch/commit info step
• Modified: go/build, go/test, go/lint, go/build-and-test, go/deps, go/smoke-test, deploy/eks, slack, ruby/lint, ruby/test — DRY refactors + summaries
• Updated: .github/workflows/test.yml — Node.js version bump
• Removed: sonarqube-scan/action.yml

Test plan

• inventory-api CI + staging deploy passes
• geo-admin CI + staging deploy passes
• Reviewer confirms no breaking changes to action interfaces

[Copilot]

Pull request overview

This PR improves the maintainability and observability of the wishabi/github-actions action suite by extracting shared branch/SHA logic into a reusable composite action, adding CI step summaries, and updating dependencies/runtimes.

Changes:

• Extract duplicated branch + short-SHA extraction into common/branch-info and reuse across composite actions.
• Add $GITHUB_STEP_SUMMARY markdown summaries to multiple Go actions for quicker CI signal.
• Bump several GitHub Actions dependencies (Node 16→20, setup-node@v3→v4, Slack action version bump) and remove the deprecated sonarqube-scan action.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
sonarqube-scan/action.yml	Removes the deprecated SonarQube composite action.
common/branch-info/action.yml	Adds reusable composite action for branch name + short SHA extraction.
slack/action.yml	Uses shared branch-info and updates Slack action version + modern $GITHUB_OUTPUT output.
go/test/test.sh	Hardens script invocation and adjusts how test output is captured.
go/test/action.yml	Adds step summary + configurable artifact retention.
go/build/action.yml	Uses branch-info, adds build summary, bumps Slack action version.
go/lint/action.yml	Uses branch-info, logs tool versions, adds lint summary, bumps Slack action version.
go/build-and-test/action.yml	Uses branch-info and bumps Slack action version.
go/smoke-test/action.yml	Uses branch-info, bumps DataDog + Slack action versions, adds smoke test summary.
go/deps/action.yml	Adds tool-version logging for easier debugging.
deploy/eks/action.yml	Uses branch-info, bumps Slack action version, fixes “Deplloyment” typo.
ruby/test/action.yml	Adds configurable artifact retention days.
ruby/lint/action.yml	Adds configurable artifact retention days.
action.yml	Bumps JavaScript action runtime to node20.
.github/workflows/test.yml	Updates Node to 20 and setup-node to v4; adds NODE_OPTIONS workaround.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.