add Tts storage cache functioins to blueprint#47
Merged
Conversation
wangpingsx
changed the title
…ver trucate the text
Contributor
|
@wangpingsx this looks good. I think this auto-save behaviour should be added in other places as well like some of the editors and the voice presets. But I can do that separately |
phil-mm
reviewed
Nov 10, 2022
| @@ -349,6 +350,12 @@ bool FWitHelperUtilities::SaveClipToAssetFile(const FString& ClipDirectory, cons | |||
| FMemory::Memcpy(CacheAsset->ClipData.GetData(), ClipData.GetData(), ClipData.Num()); | |||
|
|
|||
| (void)CacheAsset->MarkPackageDirty(); | |||
Contributor
There was a problem hiding this comment.
I wonder is it necessary to mark both the asset and the package as dirty? Maybe only the package is needed?
Contributor
Author
There was a problem hiding this comment.
I found making the asset dirty doesn't help on saving.
phil-mm
approved these changes
Nov 10, 2022
removed 140 limit, however we still log if more than 280 chars but ne…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
can auto save the storage assets.
but still not able to remove the asset on removeclips. The file can be deleted from file system, but UE editor can still see a ghost file, this is not a big issue for now, as the log mentioned, we don't support deleting asset in content, users can manually delete them.