refactor(underscore-redirects): migrate tests to typescript#16374
refactor(underscore-redirects): migrate tests to typescript#16374ocavue wants to merge 2 commits intowithastro:mainfrom
Conversation
|
|
|
||
| assert.equal(_redirects.definitions.length, 2); | ||
| assert.equal(redirects.definitions.length, 2); | ||
| }); |
There was a problem hiding this comment.
I don't see any reason to prefix this variable with a _ so I removed it in this PR.
| const resolvedRoute1: Partial<IntegrationResolvedRoute> = { | ||
| pattern: '/', | ||
| pathname: '/', | ||
| segments: [], | ||
| }; |
There was a problem hiding this comment.
Instead of doing this, create a utility called createIntegrationRoute instead. Cleaner and doesn't need all these inline types. It's also more maintainable if we need to add new tests
|
Ack, conflicts |
Will resolve tomorrow |
ocavue
force-pushed
the
ocavue-ts-test-underscore-redirects
branch
from
33a1b4e to
fc2498f
Compare
|
Conflicts resolved. |
2 participants
Migrates
packages/underscore-redirectstest files from JavaScript to TypeScript.Part of #16241