fix(render): honour compressHTML when joining head elements#16882
Open
jettwayio wants to merge 4 commits into
Open
fix(render): honour compressHTML when joining head elements#16882jettwayio wants to merge 4 commits into
jettwayio wants to merge 4 commits into
Conversation
The separator between rendered <link> and <script> tags in renderAllHeadContent was hardcoded to '\n', ignoring the existing result.compressHTML flag used elsewhere in the pipeline. Switch to a conditional separator so compressed output omits newlines between head elements, consistent with doctype injection and other compressHTML-aware rendering paths.
🦋 Changeset detectedLatest commit: d28ee20 The changes in this PR will be included in the next version bump. This PR includes changesets to release 401 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
In
renderAllHeadContent, each group of head elements — styles, links and scripts — is joined with a hardcoded'\n'separator. This ignores the existingresult.compressHTMLflag that controls whitespace in other parts of the rendering pipeline.Switch to a conditional separator so compressed output omits newlines between head elements, consistent with doctype injection and other
compressHTML-aware rendering paths.Testing
No testing required. The change only affects whitespace in rendered output and is gated behind the existing
compressHTMLflag, which is already covered by the test suite.Docs
This change does not affect docs.
compressHTMLbehaviour is unchanged — this fix brings head element rendering in line with how it is already documented.