Change how squoosh is loaded in the image integration#6548
Merged
Conversation
🦋 Changeset detectedLatest commit: 61b192d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
!preview netlify-image |
Contributor
|
Contributor
Author
|
!preview netlify-image |
Contributor
|
Contributor
Author
|
!preview netlify-image |
Contributor
|
Contributor
Author
|
!preview netlify-image |
Contributor
|
Contributor
Author
|
!preview netlify-image |
Contributor
|
Contributor
Author
|
!preview netlify-image |
Contributor
|
matthewp
commented
Mar 15, 2023
matthewp
commented
Mar 15, 2023
matthewp
commented
Mar 15, 2023
| return requestPath | ||
| }, | ||
| // @ts-expect-error | ||
| wasmBinary: bytes, |
Contributor
Author
There was a problem hiding this comment.
The emscripten wrapper code accepts this property and it's the way to provide raw bytes, but the TS types do not allow it.
Member
There was a problem hiding this comment.
I think it would be nice to have this comment in the code comment!
bluwy
reviewed
Mar 16, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
.wasmfiles in the image integration and instead creates base64 encoded versions of them. This ensures that they are bundled with the JS source code.Testing
Docs
N/A, bug fix