Skip to content

Optional Sizes prop on Picture component#6773

Merged
Princesseuh merged 7 commits intowithastro:mainfrom
doganalper:image-sizes-prop
Apr 10, 2023
Merged

Optional Sizes prop on Picture component#6773
Princesseuh merged 7 commits intowithastro:mainfrom
doganalper:image-sizes-prop

Conversation

@doganalper
Copy link
Copy Markdown
Contributor

@doganalper doganalper commented Apr 6, 2023

Changes

Set sizes prop as optional as it is not needed by default on
fixes #6125

Testing

N/A

Docs

N/A

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 6, 2023

🦋 Changeset detected

Latest commit: e6b08ad

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the pkg: integration Related to any renderer integration (scope) label Apr 6, 2023
Copy link
Copy Markdown
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@Princesseuh Princesseuh merged commit 99479e6 into withastro:main Apr 10, 2023
@astrobot-houston astrobot-houston mentioned this pull request Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[@astrojs/image] sizes and background props should be optional on <Picture>

2 participants