fix: return error instead of panic for missing frontmatter fence #1137
+64
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9dbe356 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ematipico
reviewed
Feb 3, 2026
Comment on lines
+1112
to
+1115
| Range: loc.Range{ | ||
| Loc: p.tok.Loc, | ||
| Len: 3, | ||
| }, |
Member
There was a problem hiding this comment.
Do we have snapshot tests so that we can verify that the range is correct?
Contributor
Author
There was a problem hiding this comment.
We don't have a way to do snapshots of errors, so instead I added an assertion to the test I created here: 9dbe356
ematipico
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
---) without an opening fence, the parser would panic withoriginalIM was set twiceinBodyIMand returns a helpful diagnostic error instead of panickingERROR_MISSING_FRONTMATTER_FENCE(1006)---at the beginning of their fileFixes #1133
Fixes #1038
Fixes #1094
Fixes #1107
Testing
Added test case in
packages/compiler/test/errors/missing-frontmatter-fence.tsthat verifies:Docs
Bug fix only - no documentation changes needed.