fix: avoid double-scoping nested CSS pseudo selectors#1145
Merged
Princesseuh merged 2 commits intowithastro:mainfrom Feb 17, 2026
Merged
fix: avoid double-scoping nested CSS pseudo selectors#1145Princesseuh merged 2 commits intowithastro:mainfrom
Princesseuh merged 2 commits intowithastro:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 59ca635 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…eudo selectors close withastro#1128 The pseudo-only scoping logic added in withastro#1100 did not check whether the selector was already scoped via a nesting selector (&).
tgfjt
force-pushed
the
fix/1128-css-double-scoping
branch
from
bcd7961 to
836d169
Compare
tgfjt
changed the title
Princesseuh
approved these changes
Feb 17, 2026
Member
Princesseuh
left a comment
Princesseuh
left a comment
There was a problem hiding this comment.
Tough! Thank you for this fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1128 — regression from #1100.
The pseudo-only scoping logic didn't check
!scoped, so&:last-of-type/&::beforeinside:global()got double-scoped. One-line fix: add!scopedguard, consistent with all other scoping branches.Testing
Added 6 test cases, updated 1 existing expectation. All
TestScopeStylepass.Docs
Bug fix only.