feat: emit template depth tracking instructions#1156
Open
seroperson wants to merge 1 commit intowithastro:mainfrom
Open
feat: emit template depth tracking instructions#1156seroperson wants to merge 1 commit intowithastro:mainfrom
seroperson wants to merge 1 commit intowithastro:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 75ca0b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
seroperson
force-pushed
the
i15389-template-script-dedup
branch
from
616b1f0 to
0b513fd
Compare
seroperson
force-pushed
the
i15389-template-script-dedup
branch
from
0b513fd to
75ca0b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a special handling for
<template>tags, so they call specialtemplateEnterandtemplateExitfunctions. It's necessary for withastro/astro#15980 PR.Changes
print-to-js.gonow detectstemplatenodes and addstemplateEnter/templateExitcalls inside.transform/transform.gonow fillsContainsTemplateElementflag to be able to dynamically include imports later.Testing
<template>case and nested caseDocs
I'm unsure whether it should be documented. I can add the documentation somewhere if needed.