Warn when using an expression on hoist src attr
#303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f3ddcb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
FredKSchott
reviewed
Feb 24, 2022
FredKSchott
approved these changes
Feb 24, 2022
Member
FredKSchott
left a comment
FredKSchott
left a comment
There was a problem hiding this comment.
LGTM on the concept, seems inline with the "finalize script behavior" RFC. I don't know Go code well enough to review the code though :)
natemoo-re
added a commit
that referenced
this pull request
Mar 11, 2022
* chore: enter pre * Treat all documents as fragments which generate no implicit tags (#264) * feat: remove "as", treat all documents as fragments with no implicit tags * test: fix failing tests * lint: remove unused utils * [DO NOT MERGE] add `renderHead` util to output (#265) * feat: add renderHead util to output * chore: update ci to run on `next` * test: update tests * chore: add changeset * fix transform output * Add `parse` function, emit AST (#274) * feat: implement Astro.self (#270) * feat: add parser * chore: lint * Update lib/compiler/README.md Co-authored-by: Jonathan Neal <jonathantneal@hotmail.com> Co-authored-by: Jonathan Neal <jonathantneal@hotmail.com> * chore: add changeset * test: update tests for no implicit tags * test: update tests for no implicit tags * chore: update tests for no implicit tags * chore: update build script * chore: update node bindings * chore: update wasm file * feat: expose AST types * chore: update tests for no implicit tags * [ci] release (next) (#288) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: update exposed types * [ci] release (next) (#304) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Warn when using an expression on hoist `src` attr (#303) * Warn when using an expression on hoist `src` attr * Adds a changeset * Update the warning based on feedback * [ci] release (next) (#305) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: export `./types` * [ci] release (next) (#306) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: export all shared types * fix: export named types * [ci] release (next) (#307) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Client only metadata (#308) * Include metadata on client:only components * Adds a changeset * [ci] release (next) (#309) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix next `head` behavior (#310) * feat: update WASM tests * fix: prefer astro.Parse to astro.ParseFragment * fix: prefer `Parse` to `ParseFragment` * fix: update parse test * chore: add changeset * test: add parse-ii test * [ci] release (next) (#311) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add `fragment` to AST (#312) * feat: add fragment node to AST output * fix: edge case with Fragment parsing in <head> * chore: add changeset * chore(lint): fix lint * chore(lint): fix lint * [ci] release (next) (#313) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Improve `renderHead` behavior (#315) * feat: improve render-head behavior * chore: add changeset * chore: fix wasm test * [ci] release (next) (#317) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Refactor WASM tests (#316) * refactor: switch tests to uvu * chore(ci): update test script * chore(lint): fix * test: enable head placeholder test * test: fix head placeholder test * refactor: remove escapeHTML usage, fix slot in head behavior * [ci] release (next) (#320) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: failing test * feat: expose fragment to AST (#314) Co-authored-by: Jonathan Neal <jonathantneal@hotmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Matthew Phillips <matthew@skypack.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
<script hoist src={expr}></script>.Testing
mjs test added
Docs
N/A