Skip to content

Conversation

@natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Oct 25, 2022

Changes

  • Follow-up to Move end position for elements #591
  • Internally, the start position of elements is the beginning of the tag name.
  • For our public AST, it should be the first index of the start tag.
  • This updates our AST to use the first index of the start tag for element nodes.

Testing

Tested manually

Docs

Bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2022

🦋 Changeset detected

Latest commit: 2439ff9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@natemoo-re natemoo-re merged commit 85e1d31 into main Oct 25, 2022
@natemoo-re natemoo-re deleted the fix/update-start-loc branch October 25, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants