Skip to content

Remove code that relies on v4 cookie redirects#10501

Merged
sarah11918 merged 2 commits intowithastro:mainfrom
tylerlwsmith:main
Dec 27, 2024
Merged

Remove code that relies on v4 cookie redirects#10501
sarah11918 merged 2 commits intowithastro:mainfrom
tylerlwsmith:main

Conversation

@tylerlwsmith
Copy link
Copy Markdown
Contributor

@tylerlwsmith tylerlwsmith commented Dec 21, 2024

Description (required)

Astro 5 removed introduced a breaking change where failed actions no longer redirect back to the page where a form was submitted.

This PR modifies an "actions" example that relied on the v4 behavior, making it work with Astro v5.

Related issues & labels (optional)

  • Closes N/A
  • Suggested label: code snippet update

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 21, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 302dd64
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/676ec05810a8ea0008c70a0b
😎 Deploy Preview https://deploy-preview-10501--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 21, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/actions.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 21, 2024

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

sarah11918
sarah11918 approved these changes Dec 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this @tylerlwsmith , and for taking the time to come update the code sample! We really appreciate it, and are happy to welcome you to Team Docs! 🥳

@sarah11918 sarah11918 added code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Dec 27, 2024
@sarah11918 sarah11918 merged commit 775e407 into withastro:main Dec 27, 2024
@jsparkdev jsparkdev mentioned this pull request Dec 28, 2024
Merged
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Dec 29, 2024
@thomasbnt
i18n(fr): Update guides/actions.mdx from withastro#10501
e4e632c
thomasbnt added a commit that referenced this pull request Dec 29, 2024
@thomasbnt
i18n(fr): Update guides/actions.mdx from #10544 (#10550)
a5ff8f5 
* i18n(fr): Update `guides/actions.mdx` from #10544

* i18n(fr): Update `guides/actions.mdx` from #10501

* "ctx" to "context" from #10304

Co-authored-by : Armand Philippot <git@armand.philippot.eu>
@Nin3lee Nin3lee mentioned this pull request Dec 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

No one assigned

Labels

code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tylerlwsmith @astrobot-houston @sarah11918