Skip to content

Make implementation PR can be translated#10715

Merged
liruifengv merged 4 commits intowithastro:mainfrom
liruifengv:make-implementationPR-canbe-translated
Jan 16, 2025
Merged

Make implementation PR can be translated#10715
liruifengv merged 4 commits intowithastro:mainfrom
liruifengv:make-implementationPR-canbe-translated

Conversation

@liruifengv
Copy link
Copy Markdown
Member

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jan 16, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 16, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2049aeb
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/678910f925e4f60009d615f9
😎 Deploy Preview https://deploy-preview-10715--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Jan 16, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
src/content/i18n/en.yml Source changed, localizations will be marked as outdated.
src/content/i18n/zh-CN.yml Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@liruifengv liruifengv marked this pull request as ready for review January 16, 2025 12:20
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @liruifengv!

Looks great but I noticed one small detail. The Chinese version exhibits an extra wide gap between the : and the PR title:

image

This is because the Chinese character already includes built-in whitespace but the SourcePR.astro template also includes a space between the UI string and the PR title, so we end up with + .

I think maybe we want to remove that space from the SourcePR.astro template and include it in the translated UI strings when necessary?

@liruifengv
Copy link
Copy Markdown
Member Author

liruifengv commented Jan 16, 2025

Good idea. I did that.

@liruifengv liruifengv merged commit b1d7841 into withastro:main Jan 16, 2025
@liruifengv liruifengv deleted the make-implementationPR-canbe-translated branch January 16, 2025 14:11
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Jan 16, 2025
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
thomasbnt added a commit that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants