Make implementation PR can be translated#10715
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
delucis
left a comment
There was a problem hiding this comment.
Thank you for this @liruifengv!
Looks great but I noticed one small detail. The Chinese version exhibits an extra wide gap between the : and the PR title:
This is because the Chinese : character already includes built-in whitespace but the SourcePR.astro template also includes a space between the UI string and the PR title, so we end up with : + .
I think maybe we want to remove that space from the SourcePR.astro template and include it in the translated UI strings when necessary?
|
Good idea. I did that. |
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

Description (required)
Related issues & labels (optional)