-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add missing server context from cloudflare example #10913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
|
Thanks for this @robmen ! I suspect this is exactly the change needed, but I'll tag @florian-lefebvre in to also confirm whether we should be updating this reference page/example so that we're always importing from either |
florian-lefebvre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect thanks!
|
Yes the reference should be updated too, to use |
|
Thanks Florian! @robmen Would you be able to also add the change to the reference page I linked above in my last comment? |
|
It took me a while to get back to this but I finally made the other requested update. |
|
|
||
| ## Imports from `astro:env` | ||
|
|
||
| ```js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarah11918 I wonder if should remove this codeblock entirely. There's another one below that is more useful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll ask @ArmandPhilippot to confirm, but normally this section is "everything available to import from the module". Where I guess it's a bit odd is that a user can configure other things that get imported from here, but we obviously can't know them ahead of time.
I would say we would typically keep this, to show the API. Do you agree Armand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this module is a bit special because it only has getSecret and we can import other "unfrozen" things... But, yes, I agree I think we should stay consistent with the other modules. When navigating from page to page within the same set, I think it can be helpful to keep the same structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Then I say let's get that money!!
|
Well, we let this PR sit so long that we actually fixed the Cloudflare limitation! 😅 But, we still have the other |
Description (required)
The Cloudflare example using
astro;envdid not work because it was missing the context. Adding/serverfixed it for me, so I thought I'd send the change your way. If there is a better fix, please feel free to close this PR with a better one. 😄Related issues & labels (optional)